From owner-cvs-ports@FreeBSD.ORG Fri Mar 5 09:12:21 2010 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ACA301065792; Fri, 5 Mar 2010 09:12:21 +0000 (UTC) (envelope-from tobez@tobez.org) Received: from heechee.tobez.org (heechee.tobez.org [194.255.56.42]) by mx1.freebsd.org (Postfix) with ESMTP id 6EDA18FC1B; Fri, 5 Mar 2010 09:12:21 +0000 (UTC) Received: by heechee.tobez.org (Postfix, from userid 1001) id 1239C6D401; Fri, 5 Mar 2010 10:12:20 +0100 (CET) Date: Fri, 5 Mar 2010 10:12:20 +0100 From: Anton Berezin To: Wen Heping Message-ID: <20100305091220.GB7708@heechee.tobez.org> Mail-Followup-To: Anton Berezin , Wen Heping , ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org References: <201003050042.o250gscP075349@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201003050042.o250gscP075349@repoman.freebsd.org> X-Powered-By: FreeBSD http://www.freebsd.org/ User-Agent: Mutt/1.5.20 (2009-06-14) Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/p5-Make-Cache Makefile distinfo X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2010 09:12:21 -0000 On Fri, Mar 05, 2010 at 12:42:54AM +0000, Wen Heping wrote: > wen 2010-03-05 00:42:54 UTC > > FreeBSD ports repository > > Modified files: > devel/p5-Make-Cache Makefile distinfo > Log: > - Update to 1.052 > > Feature safe: yes In my tests, this version failed its own regression tests under either one of the following two conditions: when a recent p5-Storable is installed, or when using perl 5.10.1. I suspect that in practice this is the same condition, since the version of Storable.pm supplied with perl 5.10.1 (2.20) is more recent than the version of Storable.pm installed with perl 5.8.9 (2.19). I understand that it is not realistic to expect that you would test it with and without p5-Storable installed. On the other hand, at the very least, I would expect that 1) the distribution tests are run before commit, and 2) they are run with *both* lang/perl5.8 and lang/perl5.10. Cheers, \Anton. -- Matters of elegance ought to be left to the tailor and to the cobbler. -- L. Boltzmann