From owner-freebsd-current Wed Mar 29 4: 5:24 2000 Delivered-To: freebsd-current@freebsd.org Received: from gidora.zeta.org.au (gidora.zeta.org.au [203.26.10.25]) by hub.freebsd.org (Postfix) with SMTP id 87CFF37BF6D for ; Wed, 29 Mar 2000 04:05:19 -0800 (PST) (envelope-from bde@zeta.org.au) Received: (qmail 30802 invoked from network); 29 Mar 2000 12:05:15 -0000 Received: from bde.zeta.org.au (203.2.228.102) by gidora.zeta.org.au with SMTP; 29 Mar 2000 12:05:15 -0000 Date: Wed, 29 Mar 2000 22:04:58 +1000 (EST) From: Bruce Evans X-Sender: bde@alphplex.bde.org To: Yoshinobu Inoue Cc: bmah@CA.Sandia.GOV, nnd@mail.nsk.ru, current@FreeBSD.ORG Subject: Re: 'machine/param.h' required for 'sys/socket.h' In-Reply-To: <20000329003050L.shin@nd.net.fujitsu.co.jp> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 29 Mar 2000, Yoshinobu Inoue wrote: > > > sys/socket.h: > > > #ifdef _NO_NAME_SPACE_POLLUTION > > > #include > > > #else > > > #define _NO_NAME_SPACE_POLLUTION > > > #include > > > #undef _NO_NAME_SPACE_POLLUTION > > > #endif > > > > I like this for a quick fix. Only define _ALIGN() like the current > > ALIGN(). Don't define all the variants given in your previous mail. > > I created the patches. > It become a little bit more complicated than I expected, to > avoid duplicated inclusion independently in each of namespace > polluted part and non polluted part. Now I don't like this for a quick fix :-). It is more complicated than a correct fix. I think it would be OK without any anti-redefinition ifdefs. Redefinition is only a micro-pessimization since there are only #define's (no typedefs, etc.) and won't occur often since should only be included by , and . Reinclusion can be optimized in the including file using e.g. #ifndef _ALIGN in . Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message