Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 28 Dec 2007 09:57:48 +1100 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Raja Sivaramakrishnan <srajag00@yahoo.com>
Cc:        freebsd-fs@FreeBSD.org
Subject:   Re: namei lookup vnode locking
Message-ID:  <20071228092149.T17606@delplex.bde.org>
In-Reply-To: <153149.2801.qm@web90514.mail.mud.yahoo.com>
References:  <153149.2801.qm@web90514.mail.mud.yahoo.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 Dec 2007, Raja Sivaramakrishnan wrote:

> Thanks for the response - I'll take a look at the handbook.
> Regarding ttywait, it was not called through the ttydrain ioctl.
> ttywait was called through fdfree from exit1() when the login
> process was exiting. I believe this is called with the vnode
> lock held.

Calling device close with the vnode lock held was a large bug.  It was
one of the bugs fixed in 6.2 (devfs_vnops.c 1.114.2.12 2006/10/30 by
kib MFC 1.136 by kib).  It was broken at a higher level by locking the
vnode in vn_close() starting before 6.0 (vfs_vnops.c 1.224 2005/03/13).

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071228092149.T17606>