Date: Sun, 25 Nov 2012 14:12:52 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Attilio Rao <attilio@freebsd.org> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, Giovanni Trematerra <giovanni.trematerra@gmail.com>, freebsd-arch@freebsd.org Subject: Re: [RFQ] make witness panic an option Message-ID: <20121125131252.GJ1460@garage.freebsd.pl> In-Reply-To: <CAJ-FndCnfqG4b_StS26WcPT-RhAhvJOOVryJ7rhi__y8Xkr92g@mail.gmail.com> References: <CAJ-Vmo=i=Amo_QqHi4GnGie0Gc0YnK3XaRKjvBO-=SFboFYPmA@mail.gmail.com> <CACfq090EiEiG7Ou2ZMUafWN6GLT9RNK1Q4tiOHnOBWe8GYJDjA@mail.gmail.com> <CAJ-VmonE3myRyeZ%2BAe0ZOXf7wKvC44rRVkFfDaEwnk8C-=5uoA@mail.gmail.com> <CAJ-FndCZPand_rx_uXUeetGMUZu1syGwjdFS7jv9BwdzuXvXOA@mail.gmail.com> <20121125123920.GI1460@garage.freebsd.pl> <CAJ-FndCnfqG4b_StS26WcPT-RhAhvJOOVryJ7rhi__y8Xkr92g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--/0U0QBNx7JIUZLHm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 25, 2012 at 12:42:16PM +0000, Attilio Rao wrote: > On Sun, Nov 25, 2012 at 12:39 PM, Pawel Jakub Dawidek <pjd@freebsd.org> w= rote: > > WITNESS is a development tool. We don't ship production kernels with > > WITNESS even compiled in. What is more efficient use of developer time: > > going through full reboot cycle every time or reading the warning from > > console, unloading a module, fixing the bug and loading it again? > > > > And if this option is turned off by default what is the problem? >=20 > Yes, so, why do you write here? I'm trying to understand why do you object. Until now the only concern you have that I found is that you are afraid of it being abused. I don't see how this can be abused if it is turned off by default. If someone will commit a change that will turn it on by default, believe me, I'll unleash hell personally. As I said, WITNESS is development tool, a very handy one. This doesn't mean we can't make it even more handy. It is there to help find bugs faster, right? Adrian is proposing a change that will make it help to find and fix bugs maybe even faster. > Go ahead and fix BLESSED, make it the default, etc. This is another story, but BLESSED is much less controversial to me. It is turned off by default in assumption that all the code that runs in our kernel is developed for FreeBSD, which is not true. For example ZFS is, I think, the biggest locking consumer in our kernel (around 120 locks), which wasn't originally developed for FreeBSD and locking order was verified using different tools. Now on FreeBSD it triggers massive LOR warnings from WITNESS, eventhough those are not bugs. At some point I verified many of them and they were all false-positives, so I simply turned off WITNESS warnings for ZFS locks. Why? Because BLESSED is turned off in fear of abuse, and this is turn is the cause of mentioned hack in ZFS. > I have enough of your (not referred to you particulary but to the > people which contributed to this and other thread) to not be able to > respect others opinion. > As I said I cannot forbid you guys from doing anything, just go ahead, > write the code and commit it, albeit completely bypassing other > people's opinion. I'm sorry, I wasn't aware that your opinions are set in stone. I hoped that with some new arguments you may want to reconsider:) --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl --/0U0QBNx7JIUZLHm Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlCyGVQACgkQForvXbEpPzTD7wCghovfDQb54c7N9qdn+GkhKYZH 4PkAoOK2W1rVxX032BdbCFvgrE1u8Zwv =tTdM -----END PGP SIGNATURE----- --/0U0QBNx7JIUZLHm--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121125131252.GJ1460>