From owner-freebsd-bugs@freebsd.org Fri Oct 11 07:25:03 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DAC0E140621 for ; Fri, 11 Oct 2019 07:25:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46qKGl5YWfz46Ld for ; Fri, 11 Oct 2019 07:25:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id BD02714061F; Fri, 11 Oct 2019 07:25:03 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BCC2614061D for ; Fri, 11 Oct 2019 07:25:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46qKGl4Zb4z46Lc for ; Fri, 11 Oct 2019 07:25:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 80911EC85 for ; Fri, 11 Oct 2019 07:25:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x9B7P39u061661 for ; Fri, 11 Oct 2019 07:25:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x9B7P3O3061538 for bugs@FreeBSD.org; Fri, 11 Oct 2019 07:25:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 241191] route flush panic with RADIX_MPATH Date: Fri, 11 Oct 2019 07:25:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dl@CyberPunk.ru X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Oct 2019 07:25:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241191 Bug ID: 241191 Summary: route flush panic with RADIX_MPATH Product: Base System Version: 12.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: dl@CyberPunk.ru Hello, Colleagues. We are use RADIX_MPATH . Have a lot of IPv4 route multipath. Our FreeBSD 12.0-STABLE is panic when execute `route flush`. (See details a= nd screenshots) The problem is caused by incorrect processing of return rt_unlinkrte() from sys/net/route.c . With RADIX_MPATH return may be _NULL_ with *perror =3D 0. Than rtrequest1_fib() from sys/net/route.c is panic; Also route_output() from sys/net/rtsock.c . I prepared the patch. Please check it out. If he does not contradict anything, then accept. Perhaps patch creates some other problems. However, patch solves the origin= al problem successfully. Thanks. Add details. root@noc-srr01:~ # sysctl kern | grep kern.os kern.ostype: FreeBSD kern.osrelease: 12.0-STABLE kern.osrevision: 199506 kern.osreldate: 1200503 Example 1: WITHOUT kernel options RADIX_MPATH # A lot of routes root@noc-srr01:/boot/kernel # netstat -rnW | wc -l 16132 #=20 root@noc-srr01:/boot/kernel # netstat -rnW | more Routing tables Internet: Destination Gateway Flags Use Mtu Netif Exp= ire default 10.169.211.1 UGS 3945 1500 xn0 1.1.2.0/30 10.169.213.234 UG1 0 1500 xn1 1.2.2.0/30 10.169.213.234 UG1 0 1500 xn1 1.2.3.0/30 10.169.213.234 UG1 0 1500 xn1 ... # Work flush correctly root@noc-srr01:/boot/kernel # netstat -rn | wc -l ; route -qn flush ; netst= at -rn | wc -l 16132 23 Example 2: WITH kernel options RADIX_MPATH # A lot of routes (16000 * 4 ifs and routers) root@noc-srr01:~ # netstat -rn | wc -l 63595 #=20 root@noc-srr01:~ # netstat -rn | more Routing tables Internet: Destination Gateway Flags Netif Expire default 10.169.211.1 UGS xn0 1.1.2.0/30 10.169.213.234 UG1 xn1 1.1.2.0/30 10.169.213.242 UG1 xn2 1.1.2.0/30 10.169.213.233 UG1 xn1 1.1.2.0/30 10.169.213.241 UG1 xn2 1.2.2.0/30 10.169.213.234 UG1 xn1 1.2.2.0/30 10.169.213.242 UG1 xn2 1.2.2.0/30 10.169.213.233 UG1 xn1 1.2.2.0/30 10.169.213.241 UG1 xn2 1.2.3.0/30 10.169.213.234 UG1 xn1 1.2.3.0/30 10.169.213.242 UG1 xn2 1.2.3.0/30 10.169.213.233 UG1 xn1 1.2.3.0/30 10.169.213.241 UG1 xn2 # flush panic ... see ScreenShots in attach root@noc-srr01:~ # netstat -rn | wc -l ; route -qn flush ; netstat -rn | wc= -l 63599 --=20 You are receiving this mail because: You are the assignee for the bug.=