From owner-dev-commits-ports-main@freebsd.org Sat Jun 19 19:58:32 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 139436404AC for ; Sat, 19 Jun 2021 19:58:32 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G6mnM711bz4jPL for ; Sat, 19 Jun 2021 19:58:31 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-qk1-x733.google.com with SMTP id j184so19920776qkd.6 for ; Sat, 19 Jun 2021 12:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3Lt0ePfBiMkdmUkAUKJMx6qD1hkKXuk9As007qNJsMc=; b=XlOZ90YEBabm31r+5K2R/59KT1X9c0GsM11jrbIxhhzkmFqjK0ExiwvxOT+4LLQy6Q yoZzUDT/yJ63ZOGjoL0m1IcrfNj3D87hg3GO7b3qlYsOv1AC9WH1vP6IpbDRmIwz1d2W 4QRyFL46lKDXYxJ1DVZcWmx5VX6eGgbFDohy0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3Lt0ePfBiMkdmUkAUKJMx6qD1hkKXuk9As007qNJsMc=; b=Ey6GxWQDarLYmn0lHt8ksIghBISxe8eKzh5I7C21jlb8e5DOjlT6pg30j8t0nFU4U1 wtS/aIZRnvPbjkT3tX3/nAH2zc5kJNc/1GYBFf7RV0u4c2Ks2OiIUn2c6eNJZKpz1hvz spf6awyka1qGRzRSGTcNAX198qFbCE1Bn5YCyExTaPYiJ06InBvv1IG0iVLEV4smuRng uSmCMwRv6cGJ9F9gly2Jwr04UZnCVqYbnjsnsC/XMwlg/iHnAKmCpTp4HlowHwA2aag7 qFcjrN/BS/JWyExJYPrlMldOD7moKrX5guKJ4B9WxsmLfK1VBIAf33MPOGJwhDtFzua0 cEgQ== X-Gm-Message-State: AOAM5324RbY0I0hy4h/hRXZ9JDhUFyXtGoiVqcxJq1GaMwBgpuDtqvm2 cZy3MUDts6VY/hOZZ+S9QWy+EzcGtPTj5B5SyqB+tg== X-Google-Smtp-Source: ABdhPJxAAmXCLTQO+K8WN8l5wD0+OwYdUQtVuZuDd1PcSfdeIy459CLrNy3YIZOE2nNSoKpR05hkRhC6lw3ompWWbB8= X-Received: by 2002:a5b:c:: with SMTP id a12mr21858688ybp.123.1624132710636; Sat, 19 Jun 2021 12:58:30 -0700 (PDT) MIME-Version: 1.0 References: <202106170426.15H4Q4kS068821@gitrepo.freebsd.org> <1ac24e08-fe77-4cb1-934a-50439a71c72e@FreeBSD.org> In-Reply-To: From: Kevin Bowling Date: Sat, 19 Jun 2021 12:58:18 -0700 Message-ID: Subject: Re: git: b44acc9409bd - main - graphics/mesa-libs: enable libglvnd support To: Baptiste Daroussin Cc: Kevin Bowling , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4G6mnM711bz4jPL X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jun 2021 19:58:32 -0000 On Fri, Jun 18, 2021 at 4:44 PM Baptiste Daroussin wrote= : > > > 19 juin 2021 00:46:19 Kevin Bowling : > > > On Fri, Jun 18, 2021 at 1:25 PM Baptiste Daroussin w= rote: > >> > >> > >> 17 juin 2021 06:26:08 Kevin Bowling : > >> > >>> The branch main has been updated by kbowling: > >>> > >>> URL: https://cgit.FreeBSD.org/ports/commit/?id=3Db44acc9409bd3bdd92e8= 6e35c06d50e2134b02f2 > >>> > >>> commit b44acc9409bd3bdd92e86e35c06d50e2134b02f2 > >>> Author: Jan Beich > >>> AuthorDate: 2021-06-16 15:48:02 +0000 > >>> Commit: Kevin Bowling > >>> CommitDate: 2021-06-17 04:25:27 +0000 > >>> > >>> graphics/mesa-libs: enable libglvnd support > >>> > >>> PR: 246767 > >>> Reviewed by: kbowling > >>> Tested by: kbowling > >>> Differential Revision: https://reviews.freebsd.org/D25020 > >> > >> > >> As I privately told Kevin, I am now replying here as it can be useful = for other committers. > >> > >> This commit causes a situation I would call an impossible upgrades. If= you have an ancient version of mesa-libs installed you cannot uograde to t= he new version of mesa-libs you need to first remove mesa-libs then install= libglvnd then install mesa-libs. Pkg knows how to deal with such situation= up to a limit. > >> > >> So first it is complicated because during that manipulation the system= is in an instable situation: lack of mesa-libs while things still depends = on it. > >> > >> Second if anything installed depends on mesa-libs but does not itself = has to be reinstall from the repo it will block the removal (sat solver bla= blabla message) > >> > >> To help it when you do such modification please bump portrevision of a= ll reverse dependencies! It should have be done anyway but most committers = often miss doing it. > >> > >> Best regards, > >> Bapt > > > > I'm fine prepping a review of this, I just want to be clear, increment > > PORTREVISION on around 800 ports that depended on mesa-libs? > > > > I've only seen the one report of SAT failures with xephyr so far. The > > SAT solver worked fine on my kde5 desktops. But I'd like to > > facilitate a smooth transition for everyone so happy to do whatever is > > needed. > > > > Regards, > > Kevin > > > > Tl;Dr safest approach yes but one can probably be smarter Ok, better to play it safe since this has a wide cardinality. https://reviews.freebsd.org/D30824 is ready, I'd like to get it in quick but would like to merge https://reviews.freebsd.org/D30817 right before that if anyone can help with approvals. > Bump everything which directly depends on mesa-libs is the safest way. Bu= t to be fair pkg tries to detect changes in metadata and is able to trigger= reinstallation if needed (it is the reason why poudriere is aggressively r= ebuilding reverse dependencies - for people who wonder -). So probably only= bumping reverse dependencies where after this change no metadata changes i= s probbaly sufficient. Xephyr for instance is imho only depending on mesa-l= ibs and not on libglvnd after the change. Yeah the pkg and poudriere system work very well. This has been an interesting learning experience for me too, I've been contemplating improvements to ports itself, if I can compose the thoughts into a proposal I'll send a note to ports-developers@ some time in the future. One thing that would help is to get most users out of the business of using ports directly and instead viewing it as the meta build system it is so we can wrangle issues like this in one place. I do appreciate that we handle this kind of dep work on the project side instead of offloading it to users like some other packaging systems. > I say probably here because you can imagine the complexity to test the so= lver in all possible cases, so I am not 100% sure. To be fair writting thos= e explanations for you (sincerly thank you for asking me to explain it in t= his particular case) made me think of a corner case which might help me bei= ng able to automatically catch the Xephyr case here and makes upgrade more = reliable for end users if I manage to write it is code now :) I wonder what hps is up to :) https://github.com/hselasky/libhpsat > Best regards, > Bapt