From owner-p4-projects@FreeBSD.ORG  Tue Jul  3 10:39:18 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 8FFB616A474; Tue,  3 Jul 2007 10:39:18 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3816816A468
	for <perforce@FreeBSD.org>; Tue,  3 Jul 2007 10:39:18 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 287D813C4C3
	for <perforce@FreeBSD.org>; Tue,  3 Jul 2007 10:39:18 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l63AdIMn028724
	for <perforce@FreeBSD.org>; Tue, 3 Jul 2007 10:39:18 GMT
	(envelope-from rdivacky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l63AdHRk028721
	for perforce@freebsd.org; Tue, 3 Jul 2007 10:39:17 GMT
	(envelope-from rdivacky@FreeBSD.org)
Date: Tue, 3 Jul 2007 10:39:17 GMT
Message-Id: <200707031039.l63AdHRk028721@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	rdivacky@FreeBSD.org using -f
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 122761 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jul 2007 10:39:19 -0000

http://perforce.freebsd.org/chv.cgi?CH=122761

Change 122761 by rdivacky@rdivacky_witten on 2007/07/03 10:38:33

	Actually LOCK Giant and not just check for this beeing needed and do this
	before VOP_LOCK.
	
	Suggested by: kib

Affected files ...

.. //depot/projects/soc2007/rdivacky/linux_at/sys/kern/kern_exec.c#11 edit

Differences ...

==== //depot/projects/soc2007/rdivacky/linux_at/sys/kern/kern_exec.c#11 (text+ko) ====

@@ -394,8 +394,8 @@
 	   	error = fgetvp(td, args->fd, &binvp);
 		if (error)
 			goto exec_fail;
+		vfslocked = VFS_LOCK_GIANT(binvp->v_mount);
 		VOP_LOCK(binvp, LK_EXCLUSIVE, td);
-		vfslocked = VFS_NEEDSGIANT(binvp->v_mount);
 		imgp->vp = binvp;
 	}