From owner-cvs-all Mon Feb 26 10:51:16 2001 Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 1E88E37B401; Mon, 26 Feb 2001 10:51:09 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f1QIlrl40228; Mon, 26 Feb 2001 10:47:53 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200102260736.f1Q7aPd19490@freefall.freebsd.org> Date: Mon, 26 Feb 2001 10:50:52 -0800 (PST) From: John Baldwin To: Seigo Tanimura Subject: RE: cvs commit: src/sys/dev/sound/isa emu8000.c gusmidi.c mpu.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 26-Feb-01 Seigo Tanimura wrote: > tanimura 2001/02/25 23:36:25 PST > > Modified files: > sys/dev/sound/isa emu8000.c gusmidi.c mpu.c opl.c uartsio.c > sys/dev/sound/midi midi.c midi.h midibuf.c midibuf.h > midisynth.c midisynth.h sequencer.c > sequencer.h > sys/dev/sound/pci csamidi.c > Log: > - Mutexify midi(4). The driver runs under the giant lock by default. > If you ever want to run midi(4) out of the giant lock, uncomment > MIDI_OUTOFGIANT in midi.h. Confirmed to work for csamidi with WITNESS > and INVARIANTS. Err, I hope that you do all mutex operations regardless, and only use this option to control setting the INTR_MPSAFE flag for any interrupt handlers that midi uses. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message