From owner-svn-src-all@freebsd.org  Mon Jan 22 07:51:18 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45BEDED46DC;
 Mon, 22 Jan 2018 07:51:18 +0000 (UTC)
 (envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
 by mx1.freebsd.org (Postfix) with ESMTP id 0E64B70419;
 Mon, 22 Jan 2018 07:51:17 +0000 (UTC)
 (envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.55.3])
 by phk.freebsd.dk (Postfix) with ESMTP id 0F9B52737A;
 Mon, 22 Jan 2018 07:51:10 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
 by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id w0M7osTW086600
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 22 Jan 2018 07:50:55 GMT (envelope-from phk@critter.freebsd.dk)
Received: (from phk@localhost)
 by critter.freebsd.dk (8.15.2/8.15.2/Submit) id w0M7oscC086599;
 Mon, 22 Jan 2018 07:50:54 GMT (envelope-from phk)
To: Alexey Dokuchaev <danfe@FreeBSD.org>
cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r328259 - in head: share/man/man4
 sys/arm/broadcom/bcm2835
In-reply-to: <20180122074837.GA39396@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <201801220743.w0M7hspG008170@repo.freebsd.org>
 <20180122074837.GA39396@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <86597.1516607454.1@critter.freebsd.dk>
Date: Mon, 22 Jan 2018 07:50:54 +0000
Message-ID: <86598.1516607454@critter.freebsd.dk>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jan 2018 07:51:18 -0000

--------
In message <20180122074837.GA39396@FreeBSD.org>, Alexey Dokuchaev writes:

>These changes look unrelated to the manual page.  Is this intended?

Actually they're not unrelated, I spotted the units-error while writing
the manual page.

>On a related note, this code contains a number of style bugs, you might
>want to do a quick sweep on fixing them.

There will probably be other revisions to this code and I'll fold them
in as I find them.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.