From owner-svn-src-head@freebsd.org Tue Sep 3 13:08:15 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9340DA5D6 for ; Tue, 3 Sep 2019 13:08:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N6hG6sTRz4Kry for ; Tue, 3 Sep 2019 13:08:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x729.google.com with SMTP id f10so15832469qkg.7 for ; Tue, 03 Sep 2019 06:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U8zAftZ+jxLDavNvD3FNWCmKNHCxUno6tw5zSBK2K8s=; b=CSpFYD/iqGe5lu+FOFu9/MQQqfoh6TkmsK98zy/uYroKnPOk5D3B1PK4OkVz8LP0jn rlLfGVXyUE0E7/0eKy3pCdqxVno+WtWXKvxVmW9L7m1IuRW2/ux9APTDeXIzwOlt4Cfj xvR7oaGZL9FAsQOvs9llxhbmdKBt5oHrCmTeOPAzZclD7xseXS63KRI5hQpOWpd9THnl MAThQgJzHi24H3UGpclIB9mdjqhEXKlAgXreHawn06Vbsf4x9TZZUa9KpLh4z4lIYMHR bMDTqbH0Kxz6YQQ0CzOji6mCZrgHWPYEDIZm9DWOfG9+voqhjYVUVyEF4sFX9h1ojDm9 xTyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U8zAftZ+jxLDavNvD3FNWCmKNHCxUno6tw5zSBK2K8s=; b=cp15aUif1HYL489acQ6y140YfoR0wYLyfoivVszLzLl+fWRku2V8/eb5APOnmPEtMD sedHOQxQ2Hh+G4742N3UaS2s5G3401v9sneJM7ZOdKjfg638JFvcCHWfkQft9HxMIbum vaYHdA7ozhH2VPOqH63izs7KRqmuoKX+XeTKGJ9HbHawUDblhRg9ELFu0KtHuum5Z/At oHs+RI0wy5TkcUaR1HAKHJt9UjPS90Khj7mVFgtlg+DVo2LvTyCwG8F3dx0GHvYRf15f 23SW8fBiZt3LGdF6OQ5fzxA58jDEp79yl/KDNL04vHTHGVwNA9OM+1ByH8NLofnIebdv Jtwg== X-Gm-Message-State: APjAAAUQOmmNfoO9GbOduiIitHzAd/kOWBfuScHhuqrSXn7KTZh6y8Go vyh8xRX+f8inF6w2zlFD6fHUvWIHMVyqevl4DUE9BQ== X-Google-Smtp-Source: APXvYqwwLHIn4GSOXOn+ubhozV18vYoYR0MCNty5fH79ZnSJO6+JxIObleW/Arzq/N0j6W4suMwv+0k0yu6+lvH4wb8= X-Received: by 2002:a37:4804:: with SMTP id v4mr34694530qka.60.1567516093158; Tue, 03 Sep 2019 06:08:13 -0700 (PDT) MIME-Version: 1.0 References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net> In-Reply-To: From: Warner Losh Date: Tue, 3 Sep 2019 07:08:00 -0600 Message-ID: Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys To: Mateusz Guzik Cc: Brooks Davis , Shawn Webb , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: 46N6hG6sTRz4Kry X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=CSpFYD/i; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::729) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-5.89 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; RCVD_IN_DNSWL_NONE(0.00)[9.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.90)[ip: (-9.30), ipnet: 2607:f8b0::/32(-2.82), asn: 15169(-2.30), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 13:08:15 -0000 On Tue, Sep 3, 2019, 7:02 AM Mateusz Guzik wrote: > On 9/3/19, Warner Losh wrote: > > On Tue, Sep 3, 2019, 5:45 AM Brooks Davis wrote: > > > >> On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: > >> > Hey Mateusz, > >> > > >> > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: > >> > > Author: mjg > >> > > Date: Tue Sep 3 04:16:30 2019 > >> > > New Revision: 351729 > >> > > URL: https://svnweb.freebsd.org/changeset/base/351729 > >> > > > >> > > Log: > >> > > Add sysctlbyname system call > >> > > > >> > > Previously userspace would issue one syscall to resolve the sysctl > >> and then > >> > > another one to actually use it. Do it all in one trip. > >> > > > >> > > Fallback is provided in case newer libc happens to be running on > an > >> older > >> > > kernel. > >> > > > >> > > Submitted by: Pawel Biernacki > >> > > Reported by: kib, brooks > >> > > Differential Revision: https://reviews.freebsd.org/D17282 > >> > > > >> > > Modified: > >> > ... snip ... > >> > > head/sys/sys/param.h > >> > > >> > ... snip ... > >> > > >> > > > >> > > Modified: head/sys/sys/param.h > >> > > > >> > ============================================================================== > >> > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 2019 > (r351728) > >> > > +++ head/sys/sys/param.h Tue Sep 3 04:16:30 2019 > (r351729) > >> > > @@ -60,7 +60,7 @@ > >> > > * in the range 5 to 9. > >> > > */ > >> > > #undef __FreeBSD_version > >> > > -#define __FreeBSD_version 1300044 /* Master, propagated to newvers > >> > > */ > >> > > +#define __FreeBSD_version 1300045 /* Master, propagated to newvers > >> > > */ > >> > > >> > To an outsider, it seems that __FreeBSD_version tends to be bumped in > >> > a separate commit. Am I remembering that right? > >> > >> It should be bumped in the same commit, but people forget or the bump > >> they have in their review turns into a no-op because someone else does a > >> bump in the interim (the latter has bit me several times). > >> > > > > Often when that happens to me, I'll just piggyback off the prior bump by > > just documenting the version bump as also covering what I just did. > Though > > there is some judgement too based on number of days and how bad the > effects > > in the in between zone might be. It's always a fuzzy thing if you zoom in > > on it, though, due to after the fact bumps. > > > > How do you run into this one? Your patch should fail on the file, then > patch > itself exits with an error. > Git rebase gives no error in this case. Warner -- > Mateusz Guzik >