From owner-svn-src-head@freebsd.org Tue Dec 12 19:27:54 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C4DF8E814A7; Tue, 12 Dec 2017 19:27:54 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E56A6E0D8; Tue, 12 Dec 2017 19:27:17 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id OqCreCnDHGvLHOqCse98Zv; Tue, 12 Dec 2017 12:27:11 -0700 X-Authority-Analysis: v=2.2 cv=a9pAzQaF c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=ocR9PWop10UA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=7Qk2ozbKAAAA:8 a=pGLkceISAAAA:8 a=BRVnUJJACJLM7Fuod6UA:9 a=ZTjVsfhs2AXKdQea:21 a=MrEcob16fGksjpNs:21 a=QEXdDO2ut3YA:10 a=IO5VPGILNJynrRFRW5QA:9 a=RVCD4c9FxOc2yFVT:21 a=G4ttqlYFUybfVhI7:21 a=mc6yV5WG7ZIeMsU3:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=1lyxoWkJIXJV6VJUPhuM:22 Received: from [25.81.38.66] (S0106d4ca6d8943b0.gv.shawcable.net [24.68.134.59]) by spqr.komquats.com (Postfix) with ESMTPSA id 3D13A5F1; Tue, 12 Dec 2017 11:27:09 -0800 (PST) MIME-Version: 1.0 From: Cy Schubert Subject: RE: svn commit: r326792 - head/stand/uboot/common Date: Tue, 12 Dec 2017 11:27:13 -0800 To: Mateusz Guzik , Warner Losh CC: Antoine Brodin , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers Message-Id: <20171212192709.3D13A5F1@spqr.komquats.com> X-CMAE-Envelope: MS4wfGr4uhIQ7BLBa1Q/QKaJQdR7QA/kNALaXRtvUNQZ45/U6kE3oIpt0GfLQ+2xT4Hah2dMwC8AEokxJ4u/N4Q7+qoy3C0O1ulPGIE5d8dGFxr8JXKpjBci d0IVIayBEzlDwx06wFoNTTKlCxLenpLVI3Hhj769+n8IoY6cY96CrzHpiOuPo0/46s64T+w31y3EvE2JJBTpOF9QuYmGNv+JH/3ucSnhxzh/sfcq5BjuhZ2H oOIbGUUr6gpA7NPQ6nk6/hSgOpAjFLefcdeHNrrGh7Le2YGPUdLHKMUoC2cUfe5LTc8773tvVd7DHveBl9OrVDrxxNpqiqRQEyiu6u7N1Kg= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 19:27:55 -0000 PR 224080??? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Mateusz Guzik Sent: 12/12/2017 11:13 To: Warner Losh Cc: Antoine Brodin; svn-src-head@freebsd.org; svn-src-all@freebsd.org; src-= committers Subject: Re: svn commit: r326792 - head/stand/uboot/common How about you both close one PR as a punishment and we pretend this did not happen. The thing to do was to reply to the offending commit or contact the committ= er on irc. Only in case of no timely response fixing on your own is the right = thing to do. On Tue, Dec 12, 2017 at 8:03 PM, Warner Losh wrote: The email I wrote here also sucks. It was unduly harsh. While the commit message should have been better, I was too harsh in trying to express this and giving a better example. =20 Warner =20 On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh wrote: =20 > This commit message sucks. Please use a more descriptive one in the futur= e > like "catch up to change rXXXXX that remove the argument from interact."= If > you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. > Your message is utterly useless. It doesn't even say what arch is broken= . > > Warner > > Warner > > On Dec 12, 2017 1:47 AM, "Antoine Brodin" wrote: > >> Author: antoine >> Date: Tue Dec 12 09:46:53 2017 >> New Revision: 326792 >> URL: https://svnweb.freebsd.org/changeset/base/326792 >> >> Log: >> Attempt to unbreak buildworld >> >> Modified: >> head/stand/uboot/common/main.c >> >> Modified: head/stand/uboot/common/main.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 >> (r326791) >> +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 >> (r326792) >> @@ -500,7 +500,7 @@ main(int argc, char **argv) >> archsw.arch_readin =3D uboot_readin; >> archsw.arch_autoload =3D uboot_autoload; >> >> - interact(NULL); /* doesn't return */ >> + interact(); /* doesn't return */ >> >> return (0); >> } >> >> _______________________________________________ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" =20 --=20 Mateusz Guzik =