From owner-freebsd-usb@FreeBSD.ORG Thu May 5 21:56:33 2005 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10D5D16A4CE for ; Thu, 5 May 2005 21:56:33 +0000 (GMT) Received: from mail.vicor-nb.com (bigwoop.vicor-nb.com [208.206.78.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id E5C1A43D45 for ; Thu, 5 May 2005 21:56:32 +0000 (GMT) (envelope-from julian@elischer.org) Received: from [208.206.78.97] (julian.vicor-nb.com [208.206.78.97]) by mail.vicor-nb.com (Postfix) with ESMTP id A6BA87A403; Thu, 5 May 2005 14:56:32 -0700 (PDT) Message-ID: <427A9690.9080108@elischer.org> Date: Thu, 05 May 2005 14:56:32 -0700 From: Julian Elischer User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.7) Gecko/20050423 X-Accept-Language: en, hu MIME-Version: 1.0 To: Warner Losh References: <200505050618.j456IleO001353@sep.oldach.net> <427A887F.3020108@elischer.org> <427A8EF3.70003@elischer.org> <20050505.153302.71182158.imp@bsdimp.com> In-Reply-To: <20050505.153302.71182158.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: usb@freebsd.org cc: usbcrash@oldach.net Subject: Re: recent USB MFCs cause panics X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2005 21:56:33 -0000 Warner Losh wrote: >From: Julian Elischer >Subject: Re: recent USB MFCs cause panics >Date: Thu, 05 May 2005 14:24:03 -0700 > > > >>Julian Elischer wrote: >> >>try: >> >>in usb_port.h >>comment out line 425 (as below) >> >>422 >> 423 #define config_detach(dev, flag) \ >> 424 do { \ >> 425 /* device_detach(dev); */ \ >> 426 free(device_get_ivars(dev), M_USB); \ >> 427 device_delete_child(device_get_parent(dev), dev); \ >> 428 } while (0); >> 429 >> >> > >Commenting it out is lame... I fixed this in current in uhub.c as >well as here... Since 'dev' is 0 here, I'm unsure that commenting it >out will fix the problem because the next line frees it.... > > yes I noticed that.. the next line doesn't free it, it frees the ivars which I don't think is the same thing.. the problem is that the 5.0 code does the device_delete_child() (as you see above) where 4.x did it in the device_detach() so with this merge I get the worst of both worlds.. the answer is to make uhub.c not call it's bus_child_detached() method (as 5.0 doesn't) or to make it a null function, as it clears the subdev entry which causes this problem. (see teh next email.) >Warner >_______________________________________________ >freebsd-usb@freebsd.org mailing list >http://lists.freebsd.org/mailman/listinfo/freebsd-usb >To unsubscribe, send any mail to "freebsd-usb-unsubscribe@freebsd.org" > >