From nobody Fri Jan 17 18:11:18 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YZSVG57Yrz5lGwy; Fri, 17 Jan 2025 18:11:34 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YZSVG07fCz3bLr; Fri, 17 Jan 2025 18:11:34 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of fernando.apesteguia@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=fernando.apesteguia@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-844e12f702dso70271639f.3; Fri, 17 Jan 2025 10:11:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737137492; x=1737742292; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2dysgvsc0ZhSQ+Tec8CUTtfQbQHCur5y93XuqTk2MeU=; b=KQKbgjqjzwmRJSGRawhaXTxte+CAgT3sx/j6Ji8m7EeOKwPCOwF83mxZa+EgwdkAlC dsHmagXO6NY1jDZ63hdS7pYExNTSnsJNfLyLKnHM4+aAcywhWc8uyOYhuG2gkYPIebEt iS0/7DKTFAnO8kHsbneDQuY+LQIY/EgWUSMXE7/oRGixWvr0q7EaO6fat8Qlq3ZB8HjK G5+DfhfTMuVr0F7tmIKpwzwwNUl3VtDMlZ9dOdmXEtlsUeDGBVE/rJo6hf9tU0O0Hr+M R2oCLGufVIcYpIWF5XkUvzxQI0F/HW32nqIrxuhITbjMNpszuedyCGM0mrUNW1i3lS2Y QVaw== X-Forwarded-Encrypted: i=1; AJvYcCU9h5v6YH/zR3OvYb3hTGsZJ6AQETKxCLbpsulak0DLuML9E7Lf3eDH0+NU5oRwCAqJjDVnnfro+fAy97aRBxhVbTLzprg=@freebsd.org, AJvYcCW9U7l0fGs/3wTFbV3zrL0VvY4j7eVRSFq2szcPHJtIh1GJCnqtwuZCycO8oU3ghzJbA1n7fKyDoxBzl1Ryzg0mqetSMNlBFw==@freebsd.org X-Gm-Message-State: AOJu0YxC7BX9Wu0+O8DqCgQswU5eNVBraV6TB2ZXuFSTkNOql/AYNUTZ b4acp0JJJMbusK0af9xjqgjbGJnNBdaiA2boGHKU5x+7gKpOdUAri+QjgP/h X-Gm-Gg: ASbGncvf/W6YT7yWfOMl+vYh0k54gUlUGrl7vMIZjtXSULBV6MXvoYorU8XLT9Jg2H1 axZSE4MCzP7+ciiQfeby3L69/2XV8fFrtYlJ7FcdJyWkqamGBIF666+2wPRYPaWKOkLmkIznwtd +/4WEGzYv6eoqsZZFRRbgMtutdHb3zklcpGCPRC0x5e/4rJFTDag9DeRSn8yMnk/fTyurev2LeV JVD9fHqZtyLOyXr45XBmMYg0o7bnyJ0gmXrIgo0bdZcaksM0M3VrOpBs5HZB65q38+VGysxJCXA DB29JZ+s50QYB2MDLw== X-Google-Smtp-Source: AGHT+IH5UDDUYS4eiHPtL/eIwxbsxT5ZH2hWLw13uA4jxNgMsSz50CFQb7bfwyJsAS2CHV+cJZ3jAw== X-Received: by 2002:a05:6602:4186:b0:84f:5345:1800 with SMTP id ca18e2360f4ac-851b6165b7cmr293137139f.2.1737137492187; Fri, 17 Jan 2025 10:11:32 -0800 (PST) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com. [209.85.166.44]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ea7549a1c1sm752111173.73.2025.01.17.10.11.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jan 2025 10:11:31 -0800 (PST) Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-844e12f702dso70270639f.3; Fri, 17 Jan 2025 10:11:31 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV1BIwFYxp7U89kDPaz5POoNr4lffGE6Y3GMPqLSoyh/+CKJ+HTTEZ4nrRP7Tt92cL2zs4sU0/a/rVNlSGpC9e10L4YyViIFA==@freebsd.org, AJvYcCVNLnyG4hwyCpEQUDQDE5zmhoeZBIb/cuZ2053F1YQuTucsd1es63TXeGm6FRqVkB8v8swtCj7bPzAqEq8ebAvWM5ykaTE=@freebsd.org X-Received: by 2002:a05:6602:6b08:b0:84a:51e2:6599 with SMTP id ca18e2360f4ac-851b61658aamr259167539f.1.1737137491642; Fri, 17 Jan 2025 10:11:31 -0800 (PST) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <26434658-5E5B-4197-890A-2B926AA2A487@freebsd.org> In-Reply-To: <26434658-5E5B-4197-890A-2B926AA2A487@freebsd.org> From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Fri, 17 Jan 2025 19:11:18 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: AbW1kvZz7wNhfzYKNiNkDhSirHiindFeyzrbjNOWl6C0DHJSktbgdbnlSYjM8Ys Message-ID: Subject: Re: git: a8d366898894 - main - textproc/docproj: remove gnuplot-lite dependency To: Moin Rahman Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000001d980e062bead722" X-Spamd-Result: default: False [-1.28 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-0.41)[-0.411]; FORGED_SENDER(0.30)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; NEURAL_SPAM_SHORT(0.03)[0.032]; TAGGED_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; FROM_NEQ_ENVFROM(0.00)[fernape@freebsd.org,fernandoapesteguia@gmail.com]; RCPT_COUNT_THREE(0.00)[4]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.48:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SENDERSCORE_REPUT_8(0.00)[209.85.166.48:from]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.48:from,209.85.166.44:received] X-Spamd-Bar: - X-Rspamd-Queue-Id: 4YZSVG07fCz3bLr --0000000000001d980e062bead722 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 16, 2025 at 1:21=E2=80=AFPM Moin Rahman wrot= e: > > > On 16 Jan 2025, at 13:02, Fernando Apestegu=C3=ADa = wrote: > > =EF=BB=BF > > > On Thu, Jan 16, 2025 at 8:56=E2=80=AFAM Moin Rahman wr= ote: > >> >> >> > On Jan 16, 2025, at 08:41, Fernando Apestegu=C3=ADa >> wrote: >> > >> > The branch main has been updated by fernape: >> > >> > URL: >> https://cgit.FreeBSD.org/ports/commit/?id=3Da8d3668988945bf23844a1733da2= 14113e08d6ec >> > >> > commit a8d3668988945bf23844a1733da214113e08d6ec >> > Author: Fernando Apestegu=C3=ADa >> > AuthorDate: 2025-01-14 17:26:26 +0000 >> > Commit: Fernando Apestegu=C3=ADa >> > CommitDate: 2025-01-16 07:41:00 +0000 >> > >> > textproc/docproj: remove gnuplot-lite dependency >> > >> > It was a leftover from the previous docproj. >> > --- >> > textproc/docproj/Makefile | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/textproc/docproj/Makefile b/textproc/docproj/Makefile >> > index 6d362be1878a..a0b3c298573c 100644 >> > --- a/textproc/docproj/Makefile >> > +++ b/textproc/docproj/Makefile >> > @@ -1,5 +1,6 @@ >> > PORTNAME=3D docproj >> > PORTVERSION=3D 4.1.9 >> > +PORTREVISION=3D 1 >> > CATEGORIES=3D textproc >> > >> > MAINTAINER=3D doceng@FreeBSD.org >> > @@ -7,7 +8,6 @@ COMMENT=3D Meta-port for the FreeBSD Documentation Pro= ject >> > WWW=3D https://www.freebsd.org/docproj >> > >> > RUN_DEPENDS=3D asciidoctor:textproc/rubygem-asciidoctor \ >> > - gnuplot-lite>0:math/gnuplot-lite \ >> > gohugo>=3D0.133.1,1:www/gohugo \ >> > rougify:textproc/rubygem-rouge \ >> > rubygem-asciidoctor-diagram>0:textproc/rubygem-asciidoctor-diagram >> >> I don't think this is correct. gnuplot was used to generate the graph >> of number of ports here: >> >> https://docs.freebsd.org/en/books/dev-model/#sub-project-ports > > > Interesting. I don't see any invocations to gnuplot in any of the > Makefiles. > Also, I don't have any gnuplot* packages in my system and I regularly > build the documentation just fine: > > $ DOC_LANG=3Den make > --------------------------------------------------------------- > Building the documentation > included languages: en > excluded languages: bn-bd da de el es fr hu id it ja ko mn nl pl pt-br ru > tr zh-cn zh-tw > --------------------------------------------------------------- > /usr/local/bin/ruby ./tools/global-pgpkeys-creator.rb > HUGO_DISABLELANGUAGES=3D" bn-bd da de el es fr hu id it ja ko mn nl pl pt= -br > ru tr zh-cn zh-tw" /usr/local/bin/hugo --minify > Start building sites =E2=80=A6 > hugo v0.140.2+extended freebsd/amd64 BuildDate=3D2024-12-30T17:44:54Z+000= 0 > VendorInfo=3Dfreebsd > > > | EN > -------------------+------- > Pages | 1187 > Paginator pages | 0 > Non-page files | 0 > Static files | 856 > Processed images | 0 > Aliases | 1 > Cleaned | 0 > > Total in 200805 ms > > Where is that file generated? > > It=E2=80=99s not in a Makefile. Eventually rubygem-asciidoctor-diagram ca= lls it to > generate the diagram. Search for a file where asciidoctor-diagram is > defined as a plugin. I am travelling today and will share the details at > night. > The reason the image was not properly loaded is because the syntax was wrong in d7957d161fd when this change was introduced. I just fixed it in 6abcb860ac: -.Number of ports added between 1995 and 2022 [[fig-ports]] -image::portsstatus.svg +.Number of ports added between 1995 and 2022 +[[fig-ports]] +image::portsstatus.svg[Refer to paragraphs below for a screen-reader friendly version.] I don't have any gnuplot packages in my system: $ pkg info -x '.*plot.*' pkg: No package(s) matching .*plot.* and yet with that change "make run" now shows the picture in the documentation. The CI for the documentation tree needs fixing ( https://github.com/freebsd/freebsd-ci/pull/178) so the image might not show yet in docs.freebsd.org. The image in question is generated by https://people.freebsd.org/~bofh/dropzone/dev-model.sh, which reads at the beginning: # This script will inform the total number of committers per repo at # the end of the run. This information should be manually updated in # the file documentation/content/en/books/dev-model/_index.adoc According to git log, the generated image was last updated in 2022, and I can tell you I've built the whole tree a number of times since 2022 :-) Are you sure you uploaded it to the repo and hook it to the build? Cheers. > >> >> There is an SVG file that was supposed to be generated and it has >> nothing to do with the previous docproj. >> >> >> Kind regards, >> Moin >> > --0000000000001d980e062bead722 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On = Thu, Jan 16, 2025 at 1:21=E2=80=AFPM Moin Rahman <bofh@freebsd.org> wrote:


On 16 Jan= 2025, at 13:02, Fernando Apestegu=C3=ADa <fernape@freebsd.org> wrote:

=EF=BB=BF


On Thu, Jan 16, 2025 at 8:56=E2=80=AFAM Moin = Rahman <bofh@freeb= sd.org> wrote:


> On Jan 16, 2025, at 08:41, Fernando Apestegu=C3=ADa <fernape@FreeBS= D.org> wrote:
>
> The branch main has been updated by fernape:
>
> URL: https:= //cgit.FreeBSD.org/ports/commit/?id=3Da8d3668988945bf23844a1733da214113e08d= 6ec
>
> commit a8d3668988945bf23844a1733da214113e08d6ec
> Author:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBS= D.org>
> AuthorDate: 2025-01-14 17:26:26 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Fernando Apestegu=C3=ADa <fernape@FreeBS= D.org>
> CommitDate: 2025-01-16 07:41:00 +0000
>
>=C2=A0 =C2=A0 textproc/docproj: remove gnuplot-lite dependency
>
>=C2=A0 =C2=A0 It was a leftover from the previous docproj.
> ---
> textproc/docproj/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/textproc/docproj/Makefile b/textproc/docproj/Makefile
> index 6d362be1878a..a0b3c298573c 100644
> --- a/textproc/docproj/Makefile
> +++ b/textproc/docproj/Makefile
> @@ -1,5 +1,6 @@
> PORTNAME=3D docproj
> PORTVERSION=3D 4.1.9
> +PORTREVISION=3D 1
> CATEGORIES=3D textproc
>
> MAINTAINER=3D doceng@FreeBSD.org
> @@ -7,7 +8,6 @@ COMMENT=3D Meta-port for the FreeBSD Documentation Pro= ject
> WWW=3D https://www.freebsd.org/docproj
>
> RUN_DEPENDS=3D asciidoctor:textproc/rubygem-asciidoctor \
> - gnuplot-lite>0:math/gnuplot-lite \
> gohugo>=3D0.133.1,1:www/gohugo \
> rougify:textproc/rubygem-rouge \
> rubygem-asciidoctor-diagram>0:textproc/rubygem-asciidoctor-diagram<= br>
I don't think this is correct. gnuplot was used to generate the graph of number of ports here:

https://docs.freebsd.org/en/books/dev-= model/#sub-project-ports

Interesting. I= don't see any invocations to gnuplot in any of the Makefiles.
Also, I don't have any gnuplot* packages in my system and I regularly= build the documentation just fine:

$ DOC_LANG=3De= n make
---------------------------------------------------------------Building the documentation
included languages: en
excluded language= s: bn-bd da de el es fr hu id it ja ko mn nl pl pt-br ru tr zh-cn zh-tw
= ---------------------------------------------------------------
/usr/loc= al/bin/ruby ./tools/global-pgpkeys-creator.rb
HUGO_DISABLELANGUAGES=3D&q= uot; bn-bd da de el es fr hu id it ja ko mn nl pl pt-br ru tr zh-cn zh-tw&q= uot; /usr/local/bin/hugo --minify
Start building sites =E2=80=A6
hug= o v0.140.2+extended freebsd/amd64 BuildDate=3D2024-12-30T17:44:54Z+0000 Ven= dorInfo=3Dfreebsd


=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0EN =C2=A0
-------------------+-------=C2=A0 Pages =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 1187 =C2=A0
= =C2=A0 Paginator pages =C2=A0| =C2=A0 =C2=A00 =C2=A0
=C2=A0 Non-page fil= es =C2=A0 | =C2=A0 =C2=A00 =C2=A0
=C2=A0 Static files =C2=A0 =C2=A0 | = =C2=A0856 =C2=A0
=C2=A0 Processed images | =C2=A0 =C2=A00 =C2=A0
=C2= =A0 Aliases =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A01 =C2=A0
= =C2=A0 Cleaned =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A00 =C2=A0
Total in 200805 ms
=C2=A0
Where is that file g= enerated?
It=E2=80=99s not in a Makefil= e. Eventually rubygem-asciidoctor-diagram calls it to generate the diagram.= Search for a file where asciidoctor-diagram is defined as a plugin. I am t= ravelling today and will share the details at night.


The reason the image was not properly loaded is because= the syntax was wrong in d7957d161fd when this change was introduced.
=
I just fixed it in 6abcb860ac:

-.Number of po= rts added between 1995 and 2022 [[fig-ports]]
-image::portsstatus.svg+.Number of ports added between 1995 and 2022
+[[fig-ports]]
+image:= :portsstatus.svg[Refer to paragraphs below for a screen-reader friendly ver= sion.]

I don't have any gnuplot packages i= n my system:

$ pkg info -x '.*plot.*'
p= kg: No package(s) matching .*plot.*

and yet with t= hat change "make run" now shows the picture in the documentation.=
The CI for the documentation tree needs fixing (https://github.com/freebsd/freeb= sd-ci/pull/178) so the image might not show yet in docs.freebsd.org.

The= image in question is generated by https://people.freebsd.org/~bo= fh/dropzone/dev-model.sh, which reads at the beginning:
# This script will inform the total number of committers per rep=
o at
# the end of the run. This information should be manually updated in
# the file documentation/content/en/books/dev-model/_index.adoc
=
According to git log, the generated image was last updated in 2022, and I can tell you I've built the whole tree a number of times since 2022 :-)
Are you sure you uploaded it to the repo and hook it to the build?

Cheers.




There is an SVG file that was supposed to be generated and it has
nothing to do with the previous docproj.


Kind regards,
Moin
--0000000000001d980e062bead722--