From owner-freebsd-stable@freebsd.org Mon Dec 14 14:35:57 2015 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7370BA47FE9 for ; Mon, 14 Dec 2015 14:35:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x232.google.com (mail-pf0-x232.google.com [IPv6:2607:f8b0:400e:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DE6611BC; Mon, 14 Dec 2015 14:35:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by pff63 with SMTP id 63so12071207pff.2; Mon, 14 Dec 2015 06:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-type:content-transfer-encoding:subject:date:message-id :cc:to:mime-version; bh=0BuGDa3SLjvUXSgwzNwuwT083Som3A0qpa2O9nnOZPo=; b=ETkGX6mQsD3JqxQiZUIO2+Ct/8hnQxNZnaaWCwKq5y9Y6ULtSwKSsD0RnGWyNnDrcC PGFdME1SRZ35jiKTLObAzc3V/+5zZRa6YV+b7m9Slkkz52Km6ozknh+IvGVQzCEbCGHx HTlpXHKi1/RHp7v27HIweF6vHZjAYT6g/F5WKP0ggTYEJ5RwraIXuIa8NKWDqVd/eT2+ JbMsmHfO7R7Y8POqdARIOtzOoUdw1fhvWQLyF6RZc2jBEjbfjkRBZBUNOxsBBqdJTnx1 NifmxWdRR5q+sPDbEYORO27P27SiIbWwvPlIpCaxYXE06fRUdzUvNLp2JXCbRUOQn/yv 2shA== X-Received: by 10.98.19.12 with SMTP id b12mr36175420pfj.78.1450103756792; Mon, 14 Dec 2015 06:35:56 -0800 (PST) Received: from [192.168.20.7] (c-24-16-212-205.hsd1.wa.comcast.net. [24.16.212.205]) by smtp.gmail.com with ESMTPSA id q23sm42967210pfi.34.2015.12.14.06.35.54 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Dec 2015 06:35:55 -0800 (PST) From: NGie Cooper Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: XEN kernel broken with mlx5* Date: Mon, 14 Dec 2015 06:35:52 -0800 Message-Id: <70CE8FFD-6210-43D9-8A43-A7C145E87B46@gmail.com> Cc: FreeBSD-Stable ML , =?utf-8?Q?Roger_Pau_Monn=C3=A9?= To: Hans Petter Selasky Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) X-Mailer: Apple Mail (2.2104) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Dec 2015 14:35:57 -0000 Hi HPS, It seems that XEN.i386 is broken with the mlx5* module due to a = mismatch in function definitions. Some refactoring took place on head = that appears to have =E2=80=9Cfixed=E2=80=9D this issue. Could you or = Roger please fix it? Thanks, -NGie In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/linux_radi= x.c:36: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/slab.h:38:= In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/gfp.h:38: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/page.h:38:= In file included from @/vm/vm_page.h:70: In file included from @/vm/pmap.h:90: In file included from ./machine/pmap.h:227: ./machine/xen/xenvar.h:101:9: error: 'DECLARE_BITMAP' macro redefined = [-Werror] #define DECLARE_BITMAP(name,bits) \ ^ = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/types.h:63= :9: note: previous definition is here #define DECLARE_BITMAP(n, bits) = \ ^ In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/linux_radi= x.c:37: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/kernel.h:4= 2: = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/bitops.h:3= 8:9: error: 'BITS_TO_LONGS' macro redefined [-Werror] #define BITS_TO_LONGS(n) howmany((n), BITS_PER_LONG) ^ ./machine/xen/xenvar.h:99:9: note: previous definition is here #define BITS_TO_LONGS(bits) \ ^ In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/linux_radi= x.c:37: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/kernel.h:4= 2: = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/bitops.h:3= 07:9: error: 'test_bit' macro redefined [-Werror] #define test_bit(i, a) = \ ^ ./machine/xen/xen-os.h:225:9: note: previous definition is here #define test_bit(nr,addr) \ ^ In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/linux_radi= x.c:37: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/kernel.h:4= 2: = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/bitops.h:3= 12:1: error: conflicting types for 'test_and_clear_bit' test_and_clear_bit(long bit, long *var) ^ ./machine/xen/xen-os.h:198:21: note: previous definition is here static __inline int test_and_clear_bit(int nr, volatile void * addr) ^ In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/linux_radi= x.c:37: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/kernel.h:4= 8: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/wait.h:32:= = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/spinlock.h= :51:9: error: 'spin_lock_irqsave' macro redefined [-Werror] #define spin_lock_irqsave(lock, flags) = \ ^ ./machine/xen/xen-os.h:142:9: note: previous definition is here #define spin_lock_irqsave mtx_lock_irqsave ^ In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/linux_radi= x.c:37: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/kernel.h:4= 8: In file included from = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/wait.h:32:= = /scratch/tmp/ngie/svn/sys/modules/mlx5/../../ofed/include/linux/spinlock.h= :53:9: error: 'spin_unlock_irqrestore' macro redefined [-Werror] #define spin_unlock_irqrestore(lock, flags) = \ ^ ./machine/xen/xen-os.h:143:9: note: previous definition is here #define spin_unlock_irqrestore mtx_unlock_irqrestore ^ 6 errors generated.