From owner-dev-commits-src-main@freebsd.org Wed Aug 4 14:29:51 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 88DF865F50B for ; Wed, 4 Aug 2021 14:29:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GfvJv274bz4QsX for ; Wed, 4 Aug 2021 14:29:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x732.google.com with SMTP id t66so2964892qkb.0 for ; Wed, 04 Aug 2021 07:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rxzb+z2276c5kgOp0/4sIu5xq45BT+FHvbn/l9bvtsA=; b=wuGDY8hBogFxCjbn2/DiH5CyQrZhbqC38A97Vp1Avr3sD6i5P2boOlTw2vtGl0oHpt nhtyARG7LrvVirf7xhA75dwkmeie0CnSCgQHmCus2KxRowAoykwuCbQYjPa5SvvsHygh UH6fJQLhkAlC5iRqrmJ26ctsDmaeCqjKQr2EEfV6pV+/eCo/DttJzFnuCkaDPw2e0GSt c6rCFbRVoS9QLEIpZQsdGqe9wJ/8Row7GVEBFw3oAUVNmA+QyKEov+xnD6XnQkRwbU3V Vyhti7ySeK0V/95y+PBaMNHiyny8pSAv5if8P4smT405L/07z1OD7bU78iJnTcNfmvKB ibhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rxzb+z2276c5kgOp0/4sIu5xq45BT+FHvbn/l9bvtsA=; b=cNDmsrTGF3d4oosyP3uagSB3vGNY2qrSptXvm1RCOdrWad7hqRTxynOu3PB6KxezRz nDauQiBz8QWguVr3pb/H84H9C1vaNFjB/1GlUOsPuRSVi2R57fyT+0X8fslNw/KihF3/ GlxZ1v1+8s6MkUo07+qD79CbreJumc46eWapK+GuIVGf79dOF2d8tNnzqAkROFdW8jZ+ e8YKn3lDtNmR7rwWzdg9fv1MvEAnr6ehMIq7aICWxUjGZ4PC1AImZXVPQjeXOCHOs+bx 6t3mfZnfMgbs+EDZvGUf1+NZcMeEvwAwI9zFPn3pbYd45tfNHKLtvbET6gU1ERHtO8kB dg0g== X-Gm-Message-State: AOAM530LZIIu44Mkr+S4NzypXQDMB2KxMSb/jt28EpH9BBD4ygt7v3Go Y3rpMDL6sIVMKQyTTcweIjPjovohfzw8Mr9GdaEMJA== X-Google-Smtp-Source: ABdhPJwvjObZ1tgEEjkaHfOeDiuydFrQeJvejnx1acp3XoogTDgn3l8XRtUEdxvgT91l6QO/hRJIhwfIsZb6DTI/EHI= X-Received: by 2002:a37:802:: with SMTP id 2mr26474653qki.89.1628087385371; Wed, 04 Aug 2021 07:29:45 -0700 (PDT) MIME-Version: 1.0 References: <1acb127e-1d2c-4c9f-96e6-23bfbf9695ac@FreeBSD.org> <202108041344.174DiVr0052682@gndrsh.dnsmgr.net> In-Reply-To: <202108041344.174DiVr0052682@gndrsh.dnsmgr.net> From: Warner Losh Date: Wed, 4 Aug 2021 08:29:34 -0600 Message-ID: Subject: Re: git: 184d64af1344 - main - locales: stop hardcoding the directories in the mtree To: "Rodney W. Grimes" Cc: Baptiste Daroussin , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4GfvJv274bz4QsX X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 14:29:51 -0000 On Wed, Aug 4, 2021 at 7:44 AM Rodney W. Grimes wrote: > > 3 ao?t 2021 19:32:44 Rodney W. Grimes : > > > > >> The branch main has been updated by bapt: > > >> > > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=184d64af1344d6f3c370499510cede49320f4863 > > >> > > >> commit 184d64af1344d6f3c370499510cede49320f4863 > > >> Author:???? Baptiste Daroussin > > >> AuthorDate: 2021-08-03 12:25:00 +0000 > > >> Commit:???? Baptiste Daroussin > > >> CommitDate: 2021-08-03 12:25:00 +0000 > > >> > > >> ??? locales: stop hardcoding the directories in the mtree > > >> ??? > > >> ??? The framework knows how to create directories and tag them > properly > > >> ??? for a the creation of a mtree, not need to hardcode all the > locales > > >> ??? entries in bsd.usr.mk > > >> ??? > > >> ??? This simplifies addition of new locales but also allow people > building > > >> ??? with WITHOUT_LOCALES to end up with a directory full of empty > files > > > > > > The uses of /etc/mtree go beyond the simple directory creation, > > > please cause something to build a BSD.locale.dist file and install > > > it in /etc/mtree to replace the functionality removal you have > > > just performed. > > > > > > Thanks, > > > Rod > > > > > > > Please provide a valid use case not working anymore after this change > and I will consider. > > From mtree(1): > The mtree utility compares a file hierarchy against a > specification, > > Since the shipped specification is now incomplete it can no longer be used > to do validate the hiararchy of a system against RELEASED /etc/mtree files. > install -d broke this at least a decade or more ago. Most people really don't care outside of things in /var getting created since validating directories is of such little functionality w/o also validating binaries and such. It's used in bsd.files.mk which is included by lots of things in the tree. > Note that this is not the only part of the tree where the same thing is > done. > > More regression does not make regression right. > The decision was made a long time ago to leave this feature behind, though you can still get it today if you do a NO_ROOT build because that creates a metafile that includes both directories and files for the system. pkg base uses that to generate its packages. NO_ROOT builds are better anyway, because it also lets you tag each file / directory on a per-package basis so you don't have them if you don't install a specific package. Warner > > Best, > > Bapt > -- > Rod Grimes > rgrimes@freebsd.org >