From owner-freebsd-current@FreeBSD.ORG Thu Sep 27 15:01:12 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9834D106564A; Thu, 27 Sep 2012 15:01:12 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7F0D18FC16; Thu, 27 Sep 2012 15:01:11 +0000 (UTC) Received: by bkcjf20 with SMTP id jf20so960085bkc.13 for ; Thu, 27 Sep 2012 08:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=dOIr5FYf2JS2MZzdujOh74bbANtqwvhD4CW+abzgMEQ=; b=IJCkMcj8/cGiG+Pv/RSNK6v1pW0CcAHLMvJ7Ggllh77roNFAloclcLk27raSmBJAx2 lIcGdb1LROfY0alNkf4G1v4MdPJF35wLw30XFyT7RwlMBrpkqZ5+D5lDiDm1VJXQKsQF UDKFCnTNjdTBaLQDWqL2vfmb5On95drLU3L2D0bsGbMg8qe7Wo4jgHz+VInB4dHHSCMD hkeZeAm3Xn4181DF/mlK2+Wc++a5ospolRboXOBII13ZTYPe8gPnUAZI5hHNhkK4TM0o z2IIGiw6S5hy7+Mn0W5DICbab3kiz1iwAmxfLQYQECOGvTT9+D58+sWqNADJWZD6FzUG P97g== Received: by 10.204.129.23 with SMTP id m23mr2392244bks.20.1348758070177; Thu, 27 Sep 2012 08:01:10 -0700 (PDT) Received: from localhost ([95.69.174.83]) by mx.google.com with ESMTPS id s26sm4921913bks.13.2012.09.27.08.01.08 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 27 Sep 2012 08:01:09 -0700 (PDT) Sender: Mikolaj Golub Date: Thu, 27 Sep 2012 18:01:06 +0300 From: Mikolaj Golub To: John Baldwin Message-ID: <20120927150105.GC6578@gmail.com> References: <5F3C03B6-01D0-42DE-BE9E-323DBDC90C8E@neville-neil.com> <20120921092235.GC66984@gmail.com> <505C9C58.3060006@freebsd.org> <201209251107.02279.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201209251107.02279.jhb@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Anuranjan Shukla , freebsd-current@freebsd.org, FreeBSD Current Subject: Re: Proposal for change to kernel linker for fixing a VNET and DPCPU problem. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Sep 2012 15:01:12 -0000 On Tue, Sep 25, 2012 at 11:07:02AM -0400, John Baldwin wrote: > On Friday, September 21, 2012 12:56:56 pm Julian Elischer wrote: > > On 9/21/12 2:22 AM, Mikolaj Golub wrote: > > > http://people.freebsd.org/~trociny/link_elf.c.pcpu_vnet.patch > > > > > > The fix is to make the linker on a module load recognize "external" > > > VNET/DPCPU variables defined in the previously loaded modules and > > > relocate them accordingly. For this set_pcpu_list and set_vnet_list > > > are used, where the addresses of modules 'set_pcpu' and 'set_vnet' > > > linker sets are stored in. > > > > it makes sense to me, but I really am not a linker person.. > > I think it woul be good to get Doug Rabson to weigh in on it, and > > maybe john Baldwin.. > > > > moving to -current as it's not a "net" issue really.. > > I think the proposed patch is ok. Thanks! Committed as r240997. -- Mikolaj Golub