From owner-freebsd-arch@FreeBSD.ORG Sun Oct 10 19:58:02 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA8E416A4D1 for ; Sun, 10 Oct 2004 19:58:01 +0000 (GMT) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id 39AEB43D5D for ; Sun, 10 Oct 2004 19:58:01 +0000 (GMT) (envelope-from pho@holm.cc) Received: (qmail 46314 invoked from network); 10 Oct 2004 19:57:59 -0000 Received: from 0x50a43fc7.hknxx1.adsl-dhcp.tele.dk (HELO peter.osted.lan) (80.164.63.199) by relay.pair.com with SMTP; 10 Oct 2004 19:57:59 -0000 X-pair-Authenticated: 80.164.63.199 Received: from peter.osted.lan (localhost.osted.lan [127.0.0.1]) by peter.osted.lan (8.12.10/8.12.10) with ESMTP id i9AJvwXc052163; Sun, 10 Oct 2004 21:57:58 +0200 (CEST) (envelope-from pho@peter.osted.lan) Received: (from pho@localhost) by peter.osted.lan (8.12.10/8.12.10/Submit) id i9AJvwmW052162; Sun, 10 Oct 2004 21:57:58 +0200 (CEST) (envelope-from pho) Date: Sun, 10 Oct 2004 21:57:58 +0200 From: Peter Holm To: Stephan Uphoff Message-ID: <20041010195758.GA52129@peter.osted.lan> References: <1096496057.3733.2163.camel@palm.tree.com> <1096603981.21577.195.camel@palm.tree.com> <200410041131.35387.jhb@FreeBSD.org> <1096911278.44307.17.camel@palm.tree.com> <20041004184939.GA8178@peter.osted.lan> <41619D29.1000704@elischer.org> <20041004191410.GA8423@peter.osted.lan> <4161A7BD.3040706@elischer.org> <20041005130308.GA2586@peter.osted.lan> <1097437808.80398.4.camel@palm.tree.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1097437808.80398.4.camel@palm.tree.com> User-Agent: Mutt/1.4.1i cc: Peter Holm cc: Julian Elischer cc: "freebsd-arch@freebsd.org" Subject: Re: scheduler (sched_4bsd) questions X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Oct 2004 19:58:02 -0000 On Sun, Oct 10, 2004 at 03:50:08PM -0400, Stephan Uphoff wrote: > On Tue, 2004-10-05 at 09:03, Peter Holm wrote: > > On Mon, Oct 04, 2004 at 12:42:53PM -0700, Julian Elischer wrote: > > > > OK, I got a crash dump now, after a few modifications to kern_shutdown.c > > > > There are however a few strange things worth noticing: > > > > 1) The are no panic string: > > > > Mounted root from ufs:/dev/ad0s1a. > > pid 1146: corrected slot count (2->1) > > [thread 100796] > > Stopped at sched_add+0x13: movl 0x14c(%esi),%ebx > > > > 2) The gdb stack trace gets a bit weird at: > > > > #8 0xc07812da in calltrap () at ../../../i386/i386/exception.s:140 > > #9 0xc05f0018 in flock (td=0x0, uap=0x0) at ../../../kern/kern_descrip.c:2138 > > #10 0xc0619fd1 in setrunqueue (td=0xc2319180, flags=0x0) at kern_switch.c:521 > > #11 0xc061921f in sched_wakeup (td=0xc2319180) at ../../../kern/sched_4bsd.c:859 > > > > Where did flock() come from? > > > > The full console output is at http://www.holm.cc/stress/log/cons82.html > > > > - Peter > > I am still puzzled. > My newest pet theory is that the sorting of the kg_runq is corrupted > before setrunqueue is called. > Directly changing td_priority while the thread is on the run queue would > be an explanation. > However the only instance that I found is what I think is a rare > condition where sleepq_resume_thread may be called while the thread is > on a runqueue. (John - what did I miss this time ...) > > Peter could you try this patch? > Sure, no problem. This patch + your previous changes applied to HEAD, right? - Peter > Index: subr_sleepqueue.c > =================================================================== > RCS file: /cvsroot/src/sys/kern/subr_sleepqueue.c,v > retrieving revision 1.11 > diff -u -r1.11 subr_sleepqueue.c > --- subr_sleepqueue.c 19 Aug 2004 11:31:41 -0000 1.11 > +++ subr_sleepqueue.c 10 Oct 2004 18:18:55 -0000 > @@ -642,7 +642,7 @@ > /* Adjust priority if requested. */ > MPASS(pri == -1 || (pri >= PRI_MIN && pri <= PRI_MAX)); > if (pri != -1 && td->td_priority > pri) > - td->td_priority = pri; > + sched_prio(td, pri); > setrunnable(td); > mtx_unlock_spin(&sched_lock); > } > > Should it crash again could you walk the kg_runq to verify the sorting? > > Thanks > Stephan > > > > -- Peter Holm