From owner-svn-src-head@freebsd.org  Tue Jun 27 17:06:24 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C62FD8B0E9;
 Tue, 27 Jun 2017 17:06:24 +0000 (UTC)
 (envelope-from andrew@freebsd.org)
Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16])
 by mx1.freebsd.org (Postfix) with ESMTP id 34D63746E9;
 Tue, 27 Jun 2017 17:06:23 +0000 (UTC)
 (envelope-from andrew@freebsd.org)
Received: from [IPv6:2a02:c7f:1e13:cf00:4d7f:57c8:60b0:eb3d] (unknown
 [IPv6:2a02:c7f:1e13:cf00:4d7f:57c8:60b0:eb3d])
 by fry.fubar.geek.nz (Postfix) with ESMTPSA id 4336D4E698;
 Tue, 27 Jun 2017 17:06:17 +0000 (UTC)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r320388 - head/sys/arm64/include
From: Andrew Turner <andrew@freebsd.org>
In-Reply-To: <61D9C30C-BB98-484E-B817-6FE369A77453@gmail.com>
Date: Tue, 27 Jun 2017 18:06:16 +0100
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0842F153-8120-4D7C-B6B3-E2499CD05286@freebsd.org>
References: <201706262232.v5QMWrBs048496@repo.freebsd.org>
 <61D9C30C-BB98-484E-B817-6FE369A77453@gmail.com>
To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2017 17:06:24 -0000


> On 27 Jun 2017, at 18:04, Ngie Cooper (yaneurabeya) =
<yaneurabeya@gmail.com> wrote:
>=20
>=20
>> On Jun 26, 2017, at 15:32, Andrew Turner <andrew@FreeBSD.org> wrote:
>>=20
>> Author: andrew
>> Date: Mon Jun 26 22:32:52 2017
>> New Revision: 320388
>> URL: https://svnweb.freebsd.org/changeset/base/320388
>>=20
>> Log:
>> In _bswap16 and _bswap32 cast constant values to the appropriate =
type. This is
>> similar to what is done in the x86 code.
>>=20
>> Sponsored by:	DARPA, AFRL
>=20
> Hi Andrew,
> 	This change broke htons use in libsdp on arm64. =46rom =
https://ci.freebsd.org/job/FreeBSD-head-aarch64-build/2932/console :
>=20
> 16:08:38 --- all_subdir_lib/libsdp ---
> 16:08:38 /usr/src/lib/libsdp/search.c:160:31: error: invalid operands =
to binary expression ('int' and 'uint8_t *' (aka 'unsigned char *'))
> 16:08:38                 xpdu.pdu.len =3D htons(req_cs - ss->req);
>=20
> 16:08:38                                ~~~~~~~~~~~~~^~~~~~~~~~
>=20
> 	It might be a good idea to revert the change, fix the fallout, =
then recommit the change.
> Thanks,
> -Ngie

I already fixed it in r320411.

Andrew=