Date: Tue, 19 Sep 2006 18:52:46 +0200 From: Marian Asokarajan <mail@sashi.de> To: Warner Losh <imp@bsdimp.com>, freebsd-drivers@freebsd.org Subject: Re: SDHCI Device Driver (first steps) Message-ID: <4510205E.6010606@sashi.de> In-Reply-To: <20060919.084602.71108867.imp@bsdimp.com> References: <20060918.083758.63053354.imp@bsdimp.com> <20060918.105709.179960957.imp@bsdimp.com> <450FF6B2.2000908@sashi.de> <20060919.084602.71108867.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote: > It does follow the specs, as far as I can tell. It crahsed when I > tried to fdisk the device that was created... Cool, I'm gonna boot into single user to check if that happens to the Ricoh chip too. > What's expected to work? - the driver should recognize card insertion and removal - dump sdhc's register set via /dev/sdhci0 next ToDo: - read bus architecture docs - implment bus read/write routines >>if (sc->firstBARat>0x05 || sc->slots>0x50) ... > Shouldn't slots be shifted instead? Yes, first it had ((slots>>4) > 5) but then I thought, masking slots with 0x70 leaves valid lower values and an invalid higher value. So I dropped shifting to save CPU time. > pci_get_vendorid() is what I had in mind. Ok, I'll go through the code again and do some optimization. Thanks. Best Regards, Sashi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4510205E.6010606>