From owner-cvs-all@FreeBSD.ORG Mon Mar 31 11:26:25 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C957337B401 for ; Mon, 31 Mar 2003 11:26:25 -0800 (PST) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id 43D0F43FDF for ; Mon, 31 Mar 2003 11:26:24 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 5926 invoked from network); 31 Mar 2003 19:26:30 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 31 Mar 2003 19:26:30 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h2VJQLOv016509; Mon, 31 Mar 2003 14:26:21 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: Date: Mon, 31 Mar 2003 14:26:22 -0500 (EST) From: John Baldwin To: Nate Lawson cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c if_wb.c if_xl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2003 19:26:28 -0000 On 31-Mar-2003 Nate Lawson wrote: > On Mon, 31 Mar 2003, Nate Lawson wrote: >> Modified files: >> sys/pci if_dc.c if_pcn.c if_rl.c if_sf.c if_sis.c >> if_sk.c if_ste.c if_ti.c if_tl.c if_vr.c >> if_wb.c if_xl.c >> Log: >> Clean up locking and resource management for pci/if_* > > This is a rather large patch so if you begin to experience problems > attaching or detaching (say on module load/unload) a previously-working > card, please let me know. Already found a bogon in tl(4) when it conflicted with some local changes. Might want to double check that you don't call detach() for very early failures when you have no resources to teardown or release but just do a direct return in the other drivers. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/