From owner-cvs-src@FreeBSD.ORG Tue Mar 25 15:51:21 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7F87637B401; Tue, 25 Mar 2003 15:51:21 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0162D43F93; Tue, 25 Mar 2003 15:51:21 -0800 (PST) (envelope-from mux@freebsd.org) Received: by elvis.mu.org (Postfix, from userid 1920) id D76952ED3CF; Tue, 25 Mar 2003 15:51:20 -0800 (PST) Date: Wed, 26 Mar 2003 00:51:20 +0100 From: Maxime Henrion To: Mike Silbersack Message-ID: <20030325235120.GH57674@elvis.mu.org> References: <200303250545.h2P5j5PM008552@repoman.freebsd.org> <20030324234234.T6129@odysseus.silby.com> <20030325222016.GF57674@elvis.mu.org> <20030325162048.H1250@odysseus.silby.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030325162048.H1250@odysseus.silby.com> User-Agent: Mutt/1.4i X-Spam-Status: No, hits=-32.5 required=5.0 tests=EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, REPLY_WITH_QUOTES,USER_AGENT_MUTT version=2.50 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/netinet ip_output.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Mar 2003 23:51:23 -0000 Mike Silbersack wrote: > > On Tue, 25 Mar 2003, Maxime Henrion wrote: > > > Looks like there is a bug in this code. I tried to understand what's > > wrong in the if_xl code that tries to deal with mbuf chains containing > > more than XL_MAXFRAGS mbufs, and noticed that m_head->m_pkthdr.len isn't > > set properly. The length of an mbuf chain shouldn't change when we're > > just splitting it into more mbufs, so this is kinda weird. Using > > m_fixhdr() just after the splitting code solves it, but that's probably > > just a workaround, and either m_split() or the MBUF_FRAG_TEST code needs > > to be fixed. > > Hm, the bug's probably in the frag test code. I'll take a look at it > later tonight, but you're welcome to fix it in the meantime. I committed a few fixes of mine. I hope the commit log explains the changes clearly enough. Cheers, Maxime