From owner-freebsd-rc@FreeBSD.ORG Wed Nov 30 19:01:03 2011 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1CC1E106564A; Wed, 30 Nov 2011 19:01:03 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward6.mail.yandex.net (forward6.mail.yandex.net [IPv6:2a02:6b8:0:202::1]) by mx1.freebsd.org (Postfix) with ESMTP id 8AFEE8FC29; Wed, 30 Nov 2011 19:01:02 +0000 (UTC) Received: from smtp8.mail.yandex.net (smtp8.mail.yandex.net [77.88.61.54]) by forward6.mail.yandex.net (Yandex) with ESMTP id E7E16F80C47; Wed, 30 Nov 2011 23:01:00 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1322679660; bh=Z9Y+GI7ik75nHyWEUXXexyk0AeB/x6QGtLxAurudmuI=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=O7cf9o+FDpE5MchFkDsQxCZvSPbOGMYqq3Xfh9CIE2dZgHbhYlYR2x+jWaqAGQGHZ D5sc6bYtd2DUxmVgz8ldt4V+3WHovgynW0zBaQX102pL47FIUnc1hwnu31bg5Ix9p7 HbLIhcf03Nkff8EjlpXyusOsznujGxExg0eSdcYI= Received: from smtp8.mail.yandex.net (localhost [127.0.0.1]) by smtp8.mail.yandex.net (Yandex) with ESMTP id C4DAB1B603E4; Wed, 30 Nov 2011 23:01:00 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1322679660; bh=Z9Y+GI7ik75nHyWEUXXexyk0AeB/x6QGtLxAurudmuI=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=O7cf9o+FDpE5MchFkDsQxCZvSPbOGMYqq3Xfh9CIE2dZgHbhYlYR2x+jWaqAGQGHZ D5sc6bYtd2DUxmVgz8ldt4V+3WHovgynW0zBaQX102pL47FIUnc1hwnu31bg5Ix9p7 HbLIhcf03Nkff8EjlpXyusOsznujGxExg0eSdcYI= Received: from unknown (unknown [213.138.88.133]) by smtp8.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 0xAuvd0m-10AKN98D; Wed, 30 Nov 2011 23:01:00 +0400 X-Yandex-Spam: 1 Message-ID: <4ED67D59.9080903@yandex.ru> Date: Wed, 30 Nov 2011 23:00:41 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:8.0) Gecko/20111109 Thunderbird/8.0 MIME-Version: 1.0 To: Chris Rees References: <4ED66DCB.1040102@yandex.ru> <4ED67B8F.50109@yandex.ru> In-Reply-To: X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-rc@freebsd.org Subject: Re: rc-script review request X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2011 19:01:03 -0000 Chris Rees wrote on 30.11.2011 22:55: > On 30 November 2011 18:53, Ruslan Mahmatkhanov wrote: >> Chris Rees wrote on 30.11.2011 22:15: >>> On 30 November 2011 17:54, Ruslan Mahmatkhanov wrote: >>>> Hello. >>>> >>>> I'm planning to finish repocopy of www/zope213 this evening. Would you >>>> please review rc-script that is supplied with it [1]? >>>> >>>> I get this one from www/zope211 and minimally changed it, and as far i >>>> can tell dougb@ was the last person who touched it, so it should be ok, >>>> but i'm asking for review just for the case. >>>> >>>> I'm attached the script in question and provide the link to it for the >>>> case if mailmain will eat it. >>>> >>>> Thank you much in advance. >>> >>> I could get yelled at for this, but normally I'd prefer: >> >> Please yell, i'm not experienced in rc at all, so i'll be glad any >> guidance (in any form) to raise it (experience) :). But i thought that >> it's safe to use existing scripts from the tree. >> >>> start_cmd="${name}_start" >>> >>> over >>> >>> start_cmd="zope213_start". >>> >>> Chris >> >> Fixed, thank you. I also added `KEYWORD: shutdown' per PH, because of >> zope starting under non-root user. Is there still any problems in the >> script? Updated version here: >> >> https://github.com/mexicarne/zope/blob/master/www/zope213/files/zope213.in > > I'm not going to sign you off on it, but it looks OK to me. > > Doug will be back soon :) > > Chris Og, waiting for Doug then. -- Regards, Ruslan Tinderboxing kills... the drives.