From owner-svn-src-head@freebsd.org Mon Jul 23 17:10:09 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F04510504C5; Mon, 23 Jul 2018 17:10:09 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8EC73853CE; Mon, 23 Jul 2018 17:10:08 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id heLVfgV7uWppDheLXf3Oii; Mon, 23 Jul 2018 11:10:07 -0600 X-Authority-Analysis: v=2.3 cv=YIcrNiOx c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=R9QF1RCXAYgA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=nQYHLtghUqMU1QjKQC0A:9 a=0Twf5jwiCz-Pdy4J:21 a=T2QEiDVd7MmbP0Q2:21 a=wPNLvfGTeEIA:10 a=ewwTlzS8e9JcBHLzVFQA:9 a=O-Vgo935Rrvw13y3:21 a=JxTQS23J8b3Cy4v1:21 a=Wfu566KaUAwXL-t-:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [25.80.33.197] (S0106788a207e2972.gv.shawcable.net [70.66.154.233]) by spqr.komquats.com (Postfix) with ESMTPSA id 51FE898A; Mon, 23 Jul 2018 10:10:11 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: svn commit: r336625 - head/usr.sbin/pw Date: Mon, 23 Jul 2018 10:10:14 -0700 To: Ian Lepore , Alan Somers CC: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <20180723171011.51FE898A@spqr.komquats.com> X-CMAE-Envelope: MS4wfCQTLkZxy6xgrDZGatHR3qnruWy3KbR1GYDleYtiFEkWy8C/DSRjnqkjeGNjRHt4SKnyMg7yHlRlstZJJn9ky5nnTWL/OXlcDIKordBr07Ib7S1ZZHWJ bx6e1BD4WnZMGW4Q99gnkenDhGZa9lBjbAfODqduUA9Z75pudxfkNG36T8rqXztHEKVLltu3WbWYury8bJFKOPClLFsz/nNdBYZCnKodU1rV4yXcoJcC+zX8 YndArQY+/3eJ0nL/91EJsmUsGtZfJYzb78/8N4enhKoSEr7ddbUV6S87t/D09wSno8nIs4UEd5lMxYTQ9SqWd94zZEPQJFBGHJysw9fSxVQ= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 17:10:09 -0000 Unless I'm doing something non-standard (NIS user account Kerberos authenti= cated) the rev this reverted didn't cause the ssh segfaults, though it may = have caused other issues -- I didn't look at Jenkins builds. Reverting r336= 619 resolved my ssh segfaullt. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Ian Lepore Sent: 23/07/2018 08:00 To: Alan Somers Cc: src-committers; svn-src-all@freebsd.org; svn-src-head@freebsd.org Subject: Re: svn commit: r336625 - head/usr.sbin/pw On Mon, 2018-07-23 at 08:53 -0600, Alan Somers wrote: > On Sun, Jul 22, 2018 at 5:41 PM, Ian Lepore wrote: >=20 > >=20 > > Author: ian > > Date: Sun Jul 22 23:41:40 2018 > > New Revision: 336625 > > URL: https://svnweb.freebsd.org/changeset/base/336625 > >=20 > > Log: > > =A0 Make pw(8) showuser work the same with or without -R for > > non-root > > =A0 users.=A0=A0Without -R, pw(8) uses getpwnam(3), which will open > > master.passwd > > =A0 for the root user or passwd for non-root users.=A0=A0With -R > > pw(8) was > > =A0 always opening /master.passwd, which would fail for a non- > > root > > user, > > =A0 then falsely claim the userid you're trying to show doesn't > > exist. > >=20 > > =A0 Now for a non-root user it opens /passwd and zeroes out the > > 3 > > fields > > =A0 that aren't available in the passwd file, which duplicates the > > behavior > > of > > =A0 getpwnam(3).=A0=A0The net effect is that the showuser output is > > identical > > =A0 whether using -R or not. > >=20 > > Modified: > > =A0 head/usr.sbin/pw/pw_vpw.c > >=20 > It looks like this change has broken approximately all of pw's tests. > Please fix or revert it ASAP. >=20 > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8320/testReport/ >=20 > BTW, you can easily run these tests by hand, rather than wait for > Jenkins > to do it. If you're not familiar with Kyua/atf, you can do it like > this: > 1) sudo pkg install kyua > 2) cd /usr/tests/usr.sbin/pw > 3) sudo kyua test > 4) sudo kyua report >=20 > -Alan Hrm, it worked with the admittedly simplistic testing I did by hand. I'll look into running the kyua tests and see what's going on; until I get that worked out, it's reverted in r336638. Sorry for the breakage. -- Ian