From owner-svn-src-all@freebsd.org Sun May 29 19:26:32 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 98740B537AB for ; Sun, 29 May 2016 19:26:32 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm42-vm10.bullet.mail.bf1.yahoo.com (nm42-vm10.bullet.mail.bf1.yahoo.com [216.109.114.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 518B41ED7 for ; Sun, 29 May 2016 19:26:32 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1464549665; bh=6D8GUEL+D/Gl+o3QIKC0FpORYIauHFmpltT2+7lx0ic=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=Neu2VPpq9Sd0KPT4sHQy+4nwq377/K3waChvOEJJxGaDQmWa1SAVqeL1dziU1ZnzDrYcK7m2IqJi+vvU1UhstMPoCiyzSxyKe74sfwkvn8KitIjl71Yo0xMXzfcHFGXVLne9Vk5CZDmvOy8Tx7JOgI5mRD9T6E68k4AIPT2E0V+zSQGKYIDHrzg9+b1bifjdNXn5QBkctiAi4a9oTMcBhw4ZBW2qCU6e1m0m0R/vOR669NVuHf+7fry6yFCKeTY21TJSDyidW83nYoQqg2JEIPGgibicmz2mAjBsy/g3fSIn61TXE/b9fXGelsh+gMYvc9ICBfIxSIzQE+hKdejy7g== Received: from [66.196.81.173] by nm42.bullet.mail.bf1.yahoo.com with NNFMP; 29 May 2016 19:21:05 -0000 Received: from [98.139.211.161] by tm19.bullet.mail.bf1.yahoo.com with NNFMP; 29 May 2016 19:21:05 -0000 Received: from [127.0.0.1] by smtp218.mail.bf1.yahoo.com with NNFMP; 29 May 2016 19:21:05 -0000 X-Yahoo-Newman-Id: 662170.84786.bm@smtp218.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: eRt8E8AVM1kafWbb6gZsu8E4cSIqOMjWzt0QC4KET3pNnpv uSHrPp6BbkZ_jF3DG53yxI47QBWK6MpIS3dIAlZdazLhI5sgRlK32hWPg2CF eGPTPiuYoJTga.ZzFwhymENpuTdUqpcYNLjYF8RCNYrtHFafX6DdUB7z15Pv xntlRMPoOeWRtYbp7qQ2jM32jk2A1TyxZZJt_xPdbTp2G0UsEYCTIzEUx4mM AldDOl5D3kaH04o64335GjMY4GWg34DkwuZ7xHSfjkglNIYw6uvQAhrVtP2t CcmimxVecPGpyaB0wUpDROtotbwVQE5JLtfly6DhnP1aqjXF4DMlbNvQ76iS Ra2b_4aTBxsJ0HpwiObSaGQRsZ2LxvE_Aviern6kqipO.3qfR00ah26j0dcp pqjEVZgcdK_xfJIZhhSyF5hNjy38lUjKMj51PiRfVeDOwy1WTITQ.Kp6qmOe 2iLbzS2fDBqPHCa9PNPbm3geLqs7Ynnmni3N8oWsI.XMlEtEHPFl82oiATKe HEeYpbayaFu6T5NCuHJ3iSllHEP5FWqUU X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r300961 - vendor/one-true-awk/dist To: Cy Schubert , Cy Schubert References: <201605291906.u4TJ67AT082836@slippy.cwsent.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org From: Pedro Giffuni Message-ID: <1b8c118d-0743-ba8f-5796-65b165bc8efd@FreeBSD.org> Date: Sun, 29 May 2016 14:21:29 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <201605291906.u4TJ67AT082836@slippy.cwsent.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 May 2016 19:26:32 -0000 On 05/29/16 14:06, Cy Schubert wrote: > In message <201605291817.u4TIHnN7040344@slippy.cwsent.com>, Cy Schubert > writes: >> In message <574B2EAC.3010908@FreeBSD.org>, Pedro Giffuni writes: >>> >>> >>> >>> On 29/05/2016 12:37, Cy Schubert wrote: >>>> In message <201605291618.u4TGItNJ024583@repo.freebsd.org>, "Pedro F. >>>> Giffuni" w >>>> rites: >>>>> Author: pfg >>>>> Date: Sun May 29 16:18:55 2016 >>>>> New Revision: 300961 >>>>> URL: https://svnweb.freebsd.org/changeset/base/300961 >>>>> >>>>> Log: >>>>> one-true-awk: replace 0 with NULL for pointers >>>>> >>>>> Also remove a redundant semicolon. >>>>> Submitted upstream already. >>>>> >>>>> Modified: >>>>> vendor/one-true-awk/dist/b.c >>>>> vendor/one-true-awk/dist/lex.c >>>>> vendor/one-true-awk/dist/maketab.c >>>>> vendor/one-true-awk/dist/parse.c >>>>> vendor/one-true-awk/dist/run.c >>>>> vendor/one-true-awk/dist/tran.c >>>>> >>>> Was this commit and r300962 obtained from the upline or vendor or were >>>> these commits local to FreeBSD only? >>>> >>>> >>> There is no public awk public repository AFAICT, but bwk acknowledged >>> the submission. >>> >>> The change to openresolv was merged to the public repository. >> >> As they've acknowledged the submissions, can you please tag the new >> versions of awk and openresolve with the correct upstream version numbers, >> please? > > Additionally, if there are no new version numbers, what reason is there for > polluting the vendor branch with local patches to it? Is not the vendor > branch for virgin code retrieved (or received) from the vendor (or upline)? > > Heck! Can't you simply trust the committer knows what he is doing? http://roy.marples.name/projects/openresolv/info/12cb1c1fb10df107 For nawk there is not public repository but bwk's acknowlegement said: "Thanks -- that's something that I should have done long long ago." So I think both changes are pretty much vendor code now. Pedro.