From nobody Wed Mar 12 14:55:20 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZCYZw4ZD8z5r35k; Wed, 12 Mar 2025 14:55:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZCYZw3y9Vz44Px; Wed, 12 Mar 2025 14:55:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741791320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MYCeboBOuNT6lu1SDNpxfiYN+N8rA6HmZJYgwDQ1bpc=; b=P8ChHNBrWQL4E8rDnlGE2vADzeRNldT7BV2iUlKLNf9oZWA8rsMv8Ipn5/+vhv4LQJDxpY lpIriH9rVk1RiIM1foSX+0RMWgG4Zokfg99seeYnTYfVxbcgpiBpzaScAFnv5aEKBIpfPD 4YT+U2okgfEhd3liMyarahR5C+/3LFo3QKc4Ktqq9ZPlrlr84MaFstlWzDP9MF5RduANjb QThmI1e8tyE65qZmzlKbqyAjPo73oWdKhjTx8JVKsYe7gqYbiNVvicunRHrNeVgrzYz8jC OVmYziRlJ0U8/VU978oMyKCiBcsKStIpyGfmgDkn3ohDXqjgQsBGUFJiVjYAeQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741791320; a=rsa-sha256; cv=none; b=EtqotHjcEqUROt2IY4IY7FE68DOovN3WVKkD95xCrakUsIFFs074Kk0sokSbZemgO1NNJN JqbldyOpgJw0JC09ktg1SQm1Fn6jK/+KSlNa8X82TEiInIG3ZbmLFKtwAuiJKcoJl+Y5ks prrsJBVFZpyr0farX7lpEg1EbDTn+uP2hsAMKsP+1RhrYTKlSa+dEzAFFvXQE5bTcvUx8y T/LS9IYq+6IoY9T/NB7EvPml40WyLK7W3k8RPmirVNugX5IpPpnm6FY3Sw7rS+51ZGeFsb hwmSFfVUieynBDORZN2LyiADJsxbBoQLurV/cJ05fcGbbfzBJUNyYgQi1e9Ltg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741791320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MYCeboBOuNT6lu1SDNpxfiYN+N8rA6HmZJYgwDQ1bpc=; b=YpIxqj6n2r1J7PCIrv3oAbxcy4perIu5Tq9rH7kMyZkBPCLxH3FKXIm+zlK7rhrMG20PmC 6+PHAqs/LPiINZnclOPi4HcW4jriIiPL61AOOfSVke7DB2gmdEnESqbVWyikeJ2u0/gyzd nYPmIE1Xm3uAMlTBtb3RRBhkzHpKrOBccs8WxvU89DyJ8GGSx+qb54J09THJ2PcbnN7nIl uKFuWrKvxEqqXkJkOsdHQ7JS5WIFfmv4yPFw2Gagx5pxI3o28IfTwwoySZsN9v6jqHkANG yATZZr7Dk8Z9MZNDBsQQwq0KtmdaNDFTVr3CxShwrxmwO1lYOkHP5BwXrSgylg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZCYZw2jxyz1tC; Wed, 12 Mar 2025 14:55:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52CEtKBW015077; Wed, 12 Mar 2025 14:55:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52CEtKGm015074; Wed, 12 Mar 2025 14:55:20 GMT (envelope-from git) Date: Wed, 12 Mar 2025 14:55:20 GMT Message-Id: <202503121455.52CEtKGm015074@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: ba6c35f0cadb - main - usb: Use bus_detach_children instead of bus_generic_detach List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ba6c35f0cadbbcf37a89f193609c6dc90f08a8b2 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=ba6c35f0cadbbcf37a89f193609c6dc90f08a8b2 commit ba6c35f0cadbbcf37a89f193609c6dc90f08a8b2 Author: John Baldwin AuthorDate: 2025-03-12 14:53:16 +0000 Commit: John Baldwin CommitDate: 2025-03-12 14:54:49 +0000 usb: Use bus_detach_children instead of bus_generic_detach The USB bus performs additional teardown steps in between detaching child devices and deleting child devices. Reported by: phk, thj Tested by: phk Fixes: e9d3857040a1 ("Use bus_detach_children instead of bus_generic_detach") --- sys/dev/usb/controller/usb_controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/usb/controller/usb_controller.c b/sys/dev/usb/controller/usb_controller.c index d717ad56adea..7e89a5ab0155 100644 --- a/sys/dev/usb/controller/usb_controller.c +++ b/sys/dev/usb/controller/usb_controller.c @@ -438,7 +438,7 @@ usb_bus_detach(struct usb_proc_msg *pm) /* detach children first */ bus_topo_lock(); - bus_generic_detach(dev); + bus_detach_children(dev); bus_topo_unlock(); /*