From owner-freebsd-net@freebsd.org  Mon Jul 13 22:16:00 2015
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8877299CE3E
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Mon, 13 Jul 2015 22:16:00 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-ig0-x229.google.com (mail-ig0-x229.google.com
 [IPv6:2607:f8b0:4001:c05::229])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 55E0BFA8;
 Mon, 13 Jul 2015 22:16:00 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: by iggp10 with SMTP id p10so86168896igg.0;
 Mon, 13 Jul 2015 15:15:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=4HZS4dXNoPi7ThfQUmPMIfO541pUjyM1o6I+sBbOBMY=;
 b=q3zIgG1B+3f0sdLUWvaXUgeL67eCgxdcLugoTjvV6ldykPmXUp2zWbTb7cN2wZVuFD
 7K8Fz2U5JVxiBvVnZLy0Tw7SMgCY6YN4MTKfzsT4R6/+1zTgWRYr0mV/yy1fpF5vJT+H
 IIgniFtvyoL24LUz100Qpb5wiWxoOWePowZDVeCT/g2V6kICoKSS03u3pTtACdfqM6HN
 J675Slqk/gHJyXw7z1weU5gedh6ea8j35V6eV7nWIMi+pD8LJ6Ui5XVRfgbUp2NAvZb0
 LJy4oKRqzUlvXZ2ub9maIdeXSFLxo3u/tKd81vZacoceJY4bvtTwtU1FT9Q7C8NgaYoz
 pWCQ==
MIME-Version: 1.0
X-Received: by 10.107.27.195 with SMTP id b186mr19122825iob.140.1436825759765; 
 Mon, 13 Jul 2015 15:15:59 -0700 (PDT)
Received: by 10.36.38.133 with HTTP; Mon, 13 Jul 2015 15:15:59 -0700 (PDT)
In-Reply-To: <20150713200513.GD22795@strugglingcoder.info>
References: <20150713200513.GD22795@strugglingcoder.info>
Date: Mon, 13 Jul 2015 15:15:59 -0700
Message-ID: <CAJ-VmonHN9KrXFfDtjqwg37EnGxYkJ+VaHT5SO-rWsTX3z5Jwg@mail.gmail.com>
Subject: Re: Exposing full 32bit RSS hash from card for ixgbe(4)
From: Adrian Chadd <adrian.chadd@gmail.com>
To: hiren panchasara <hiren@freebsd.org>
Cc: FreeBSD Net <freebsd-net@freebsd.org>, Eric Joyner <erj@freebsd.org>, 
 "scottl@freebsd.org" <scottl@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2015 22:16:00 -0000

Hi,

It's fine by me. Please do it!


-a


On 13 July 2015 at 13:05, hiren panchasara <hiren@freebsd.org> wrote:
> Here is the patch I'd like to push which exposes 32bit RSS has that we
> get from ixgbe cards irrespective of whether RSS is defined or not.
>
> https://people.freebsd.org/~hiren/patches/ix_expose_rss_hash.patch
>
> This is similar to what we've done for igb(4): r281838
>
> In this patch I am also proposing to remove FreeBSD version check (and
> therefore the check for M_FLOWID) as I don't see such a check in other
> Intel drivers like igb(4). But I am on adamant wrt that and can restore
> if someone feels strongly about it.
>
> (I need to update my arc client (again) to generate the phabric review
> and that can take some time so I'd appreciate any reviews/comments
> here.)
>
> Cheers,
> Hiren