From owner-freebsd-ports@FreeBSD.ORG Wed Dec 19 19:03:25 2007 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3C28B16A41A; Wed, 19 Dec 2007 19:03:25 +0000 (UTC) (envelope-from pauls@utdallas.edu) Received: from smtp3.utdallas.edu (smtp3.utdallas.edu [129.110.10.49]) by mx1.freebsd.org (Postfix) with ESMTP id 2923D13C467; Wed, 19 Dec 2007 19:03:24 +0000 (UTC) (envelope-from pauls@utdallas.edu) Received: from utd59514.utdallas.edu (utd59514.utdallas.edu [129.110.3.28]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp3.utdallas.edu (Postfix) with ESMTP id 74492654A6; Wed, 19 Dec 2007 13:03:24 -0600 (CST) Date: Wed, 19 Dec 2007 13:03:23 -0600 From: Paul Schmehl To: FreeBSD Ports Message-ID: <41364CD63DE952CCB8602A44@utd59514.utdallas.edu> In-Reply-To: <47693FE9.20701@gahr.ch> References: <4D1AAAB26DADCFB11343F6B3@utd59514.utdallas.edu> <47693FE9.20701@gahr.ch> X-Mailer: Mulberry/4.0.8 (Linux/x86) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline Cc: pav@FreeBSD.org, Pietro Cerutti Subject: Re: Optional patching X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2007 19:03:25 -0000 --On Wednesday, December 19, 2007 16:59:37 +0100 Pietro Cerutti wrote: > Paul Schmehl wrote: >> Is there a way to include a patch as an option to a port? I maintain >> the security/barnyard port. There's a patch that is necessary for >> barnyard to work correctly on a 64bit system. I'm wondering if I can >> use OPTIONS to make this patch optional if the system is 64 bit, but I'm >> not sure what the syntax would be inside the if statement. >> >> .if defined(WITH_64BIT) >> do-patch: patchname >> .endif > > > I would do something like (please check the list of 64 bits platforms) > > .if ${ARCH} == "amd64" || ${ARCH} == "ia64" || ${ARCH} == "sparc64" ># apply the patch here > .endif > >> >> I assume the patch would have to be in the filesdir but could not be >> named "patch-foo" or it would always be applied, correct? >> > > Please check the reply from pav@ for this ;-) That brings up an interesting question. Which would be the preferred method? To use an OPTION knob? Or simply apply the patch if the arch matches? I'm thinking the latter. I've tested the former method, and it works fine. Does it matter which method I use? -- Paul Schmehl (pauls@utdallas.edu) Senior Information Security Analyst The University of Texas at Dallas http://www.utdallas.edu/ir/security/