From nobody Sun Aug 9 07:20:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hHq6F4d8Fz6nCs7; Sun, 09 Aug 2026 07:20:21 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from fout-a4-smtp.messagingengine.com (fout-a4-smtp.messagingengine.com [103.168.172.147]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4hHq6F2X3Kz3ZSx; Sun, 09 Aug 2026 07:20:21 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id EA265EC017D; Sun, 9 Aug 2026 03:20:19 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-09.internal (MEProxy); Sun, 09 Aug 2026 03:20:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gojira.at; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1786260019; x=1786346419; bh=Dtek7XZHeX eg2f7SjbeVJ1QhWEz/GP+Xc07EVebTwVE=; b=fz+R6wv/w9uK7LdJVeqSOKBm87 6a9STHfDoHMyP+NxFrlA7dAyzkLDTp4ozJQe2Z+AsIxNRVwLuDhUaHUF7vC7Bt6O FyS28Xclwk+K8FmCc8lpYsHsop/rwRJ3Rgb6uRBd11J6ylmFilr4N3DoxoGmU1zv HVZLDwnjPhL8/qDqr6IIeNL6Kz62yhhjgLaBQYTtL8/nXvw0RiLtrj6XN9sX6uJg 1a1Y04PkFb0wbFpgKr15KkwUhIf1bvgaiPTLjJoijLY2eDUu973EEvj2IxaKTfDo z/88BaB5ed+xzGh77MmzoMsFGvjyoskC3Xxp8U3Way2xyO2tXOgT2JjSqtsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1786260019; x=1786346419; bh=Dtek7XZHeXeg2f7SjbeVJ1QhWEz/GP+Xc07 EVebTwVE=; b=XKxof03PI6uZnhrN6IA9P9CET/quQArMWoTZh8GaAPKQMLvZsV9 eSUPmT2Eq769H9T+8NJmSe9hFaYa0i0ZD2yNluEWP8duGIXRLz+ZgtFAwwOp/G18 fOxPj/OJAjvklDll0Vz4Oz6u8wgWuXi4JB+5q0pEMLrb9j9TyfwX/cexJ39PJaQM qvFSehtcsKJAudoJULTVF8jmQuieGbgnAfASQLTH54+bgEePtG1niW4X8eJYzrin 9qy8a0N8idiNWltmyrSmkje9mGS+1n1ALumj6fCwWu33uARC3lkeI7JNCgwuDEPm FDSvNoY8ewEgyIsfyE6CRUvGYqpaNvamFXg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFa8YQzbWk0nlCCD2GGyOMIXR8e5XfTOqqmxVu8nHnVEjRwClTOa7WPw06+ODoxar tM631OslNu8BhwHnTi828JYaK6vmigpKEjBW6N02eLc27CAp6M6wjlgVLsO4kJgLTPL5lP 0+T9syHXWbNslYfLMAEgBS6WSidL2HWoxj3saOZvL0LjKPrJZnBzfscr4B8Cky0gpqmXFl 1o9mjAgEP0qozAIvzMcYk7VEmWyccUF71ppSt1xMl4OGtKnEGc4eDrvemwp5zY5myX00mr s/6el29Mq72IuxZOPnSoSaDQBNP/+u3deKK+W189iMgv8eciDPIJYbcfTh8+iSffETHrPM lDuHuvqk/NddUyz/4xPS0L//dG0CzV87PzQRDCBuhehYIC1BSKOoFVI2SZS6d51K1Vvp6k FiLwzgMEjeZSmPYe6HKUJtWIUNb50/SFQwf506lx5lQon8UgsR2ABBRV6IqmkFEFPmw36U ta6Q3s7aezIEipqBJf7kOs/uSp3v3HYknPPZUlcvy3c7sXN3mEpZnxqLJm7DRY3/4cncIX quMXWf5IjcMBQwjJeKrvpoU4sEdogkQSrQPJULSKC3NK4726y8HHn75319IKDXSD9jbPzG 74F2gsCdb2BRCQ0Pgd6gLPWfmp+UwrHhsEAD+wZ2S/SC7z7URx8llUCVusxw X-ME-Proxy: Feedback-ID: i64fe486c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Aug 2026 03:20:18 -0400 (EDT) Date: Sun, 09 Aug 2026 09:20:16 +0200 Message-ID: <87fr0nn4jz.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Kevin Bowling Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2d6114f6d26b - main - libifconfig: Add an SR-IOV VF status query In-Reply-To: <6a782291.18052.6103210b@gitrepo.freebsd.org> References: <6a782291.18052.6103210b@gitrepo.freebsd.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/32.0 Mule/6.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4hHq6F2X3Kz3ZSx X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:151847, ipnet:103.168.172.0/24, country:AU] X-Spamd-Bar: ---- On Sun, 09 Aug 2026 08:47:45 +0200, Kevin Bowling wrote: > > The branch main has been updated by kbowling: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2d6114f6d26bf7dfa5ad94e1db9b09ee7108dc7a > > commit 2d6114f6d26bf7dfa5ad94e1db9b09ee7108dc7a > Author: Kevin Bowling > AuthorDate: 2026-08-09 02:03:20 +0000 > Commit: Kevin Bowling > CommitDate: 2026-08-09 06:46:41 +0000 > > libifconfig: Add an SR-IOV VF status query > > Provide a public helper which retrieves, unpacks, and validates the > versioned VF status nvlist. Validate the required VF indices and the > shape and version of driver-specific extension namespaces while allowing > unknown optional fields. > > The ioctl argument is not copied back when the command returns EFBIG. > Start with a practical buffer and grow it geometrically rather than > relying on the required length being observable. > > Use the helper in ifconfig so other consumers share the same transport > and validation behavior. > --- > lib/libifconfig/Makefile | 2 +- > lib/libifconfig/Symbol.map | 4 ++ > lib/libifconfig/libifconfig.c | 129 ++++++++++++++++++++++++++++++++++++++++++ > lib/libifconfig/libifconfig.h | 11 ++++ > sbin/ifconfig/ifvfstatus.c | 60 +++----------------- > share/mk/src.libnames.mk | 4 +- > 6 files changed, 154 insertions(+), 56 deletions(-) This breaks buildworld: >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_get_vf_status) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a ld.lld: error: undefined symbol: FreeBSD_nvlist_get_number >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a ld.lld: error: undefined symbol: FreeBSD_nvlist_exists_nvlist_array >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a ld.lld: error: undefined symbol: FreeBSD_nvlist_get_nvlist_array >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a ld.lld: error: undefined symbol: FreeBSD_nvlist_exists >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a ld.lld: error: undefined symbol: FreeBSD_nvlist_exists_nvlist >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a ld.lld: error: undefined symbol: FreeBSD_nvlist_get_nvlist >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a ld.lld: error: undefined symbol: FreeBSD_nvlist_next >>> referenced by libifconfig.c >>> libifconfig.o:(ifconfig_vf_status_validate) in archive /usr/obj/home/herbert/sources/freebsd/main/src/amd64.amd64/lib/libifconfig/libifconfig.a cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [rescue] Error code 1