From owner-svn-src-head@FreeBSD.ORG  Sat Jan  5 09:30:10 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id 16EF21D0;
 Sat,  5 Jan 2013 09:30:10 +0000 (UTC) (envelope-from jh@FreeBSD.org)
Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi
 [195.197.172.115])
 by mx1.freebsd.org (Postfix) with ESMTP id CBA59692;
 Sat,  5 Jan 2013 09:30:09 +0000 (UTC)
Received: from a91-153-116-96.elisa-laajakaista.fi
 (a91-153-116-96.elisa-laajakaista.fi [91.153.116.96])
 by gw01.mail.saunalahti.fi (Postfix) with SMTP id 8124B15150F;
 Sat,  5 Jan 2013 11:22:53 +0200 (EET)
Date: Sat, 5 Jan 2013 11:22:52 +0200
From: Jaakko Heinonen <jh@FreeBSD.org>
To: John Baldwin <john@baldwin.cx>
Subject: Re: svn commit: r244585 - in head: . sys/geom/label
Message-ID: <20130105092252.GA1832@a91-153-116-96.elisa-laajakaista.fi>
References: <201212221343.qBMDhCHa086834@svn.freebsd.org>
 <201301041218.07804.john@baldwin.cx>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201301041218.07804.john@baldwin.cx>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Jan 2013 09:30:10 -0000

On 2013-01-04, John Baldwin wrote:
> > New Revision: 244585
> > Log:
> >   Mangle label names containing spaces, non-printable characters '%' or
> >   '"'.  Mangling is only done for label names read from file system
> >   metadata. Encoding resembles URL encoding. For example, the space
> >   character becomes %20.
> 
> Ouch, mangling spaces seems unfortunate.  I guess fixing the devctl protocol 
> is too hard, and/or we can't just encode it at the protocol layer but leave 
> the actual device names untouched?

I initially proposed changing the devctl protocol but in a private
discussion people preferred to not change the protocol. However, I think
that allowing the space character only might be possible without
changing the protocol as devd(8) can already handle strings enclosed in
double quotes. usb(4) already uses such devctl variables.

> OS X preserves spaces in volume names and those can be quite common on
> ISO images, so mangling them really does seem to be a shame if we can
> avoid it.

How important do you think this is? I understand that it's annoyance for
people upgrading their systems but labels with spaces can still be used.

-- 
Jaakko