Date: Thu, 14 Jul 2011 21:17:11 +0200 From: Pav Lucistnik <pav@FreeBSD.org> To: Jung-uk Kim <jkim@FreeBSD.org> Cc: Montgomery-Smith <stephen@FreeBSD.org>, "lioux@FreeBSD.org" <lioux@FreeBSD.org>, Stephen Montgomery-Smith <stephen@missouri.edu>, freebsd-ports@FreeBSD.org, Stephen, "demon@FreeBSD.org" <demon@FreeBSD.org> Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES (take 2) Message-ID: <1310671031.23182.9.camel@hood.oook.cz> In-Reply-To: <201107141515.28791.jkim@FreeBSD.org> References: <201107121826.00020.jkim@FreeBSD.org> <201107141347.39261.jkim@FreeBSD.org> <4E1F2D7E.4090200@missouri.edu> <201107141515.28791.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-mWnqQyTzejebGCzd4gUG
Content-Type: text/plain; charset="ISO-8859-2"
Content-Transfer-Encoding: quoted-printable
Jung-uk Kim p=ED=B9e v =E8t 14. 07. 2011 v 15:15 -0400:
> On Thursday 14 July 2011 01:55 pm, Stephen Montgomery-Smith wrote:
> > On 07/14/2011 12:47 PM, Jung-uk Kim wrote:
> > > Anyhow, I guess we can do it much simpler:
> > >
> > > --- Mk/bsd.port.mk 3 Jul 2011 15:51:18 -0000 1.687
> > > +++ Mk/bsd.port.mk 14 Jul 2011 17:26:43 -0000
> > > @@ -6432,7 +6432,7 @@
> > > ${ECHO_CMD} "@cwd ${DESKTOPDIR}">> ${TMPPLIST}; \
> > > fi; \
> > > while [ $$# -gt 6 ]; do \
> > > - filename=3D"`${ECHO_CMD} "$$4" | ${TR} -cd [:alnum:]`.desktop";
> > > \ + filename=3D"`${BASENAME} "$$4" | ${SED} -E
> > > 's/[[:space:]]+.*//'`.desktop"; \
> > > pathname=3D"${DESKTOPDIR}/$$filename"; \
> > > categories=3D"$$5"; \
> > > if [ -z "$$categories" ]; then \
> > >
> > > I think this is much simpler and better fix.
> > >
> > > Jung-uk Kim
> >
> > I agree.
>=20
> I'll commit this version tomorrow unless I see more objection.
Eh, don't you need to get portmgr@ approval before touching bsd.port.mk
by any chance ???
I could support allowing dash as one extra allowed char, and having that
change exp-run'ed.
--=20
--=20
Pav Lucistnik <pav@oook.cz>
<pav@FreeBSD.org>
> With a 10 MHz 386 the downloading speed would most likely drop > to a
crawl or stop with the decoding process etc. I think most 10MHz 386
users are quite accustomed to things dropping to a crawl.
--=-mWnqQyTzejebGCzd4gUG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iEYEABECAAYFAk4fQLcACgkQntdYP8FOsoLsogCfVUPUuhraakJ7+gzQ+xc6FTew
exQAn2Hdrn+Ye92g4venrCkTYH1QktbB
=+CWZ
-----END PGP SIGNATURE-----
--=-mWnqQyTzejebGCzd4gUG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1310671031.23182.9.camel>