From owner-p4-projects@FreeBSD.ORG  Sat Jan 23 22:25:17 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B18361065672; Sat, 23 Jan 2010 22:25:17 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 75D3A106566C
	for <perforce@freebsd.org>; Sat, 23 Jan 2010 22:25:17 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 621B28FC16
	for <perforce@freebsd.org>; Sat, 23 Jan 2010 22:25:17 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o0NMPHOJ031054
	for <perforce@freebsd.org>; Sat, 23 Jan 2010 22:25:17 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o0NMPHaE031052
	for perforce@freebsd.org; Sat, 23 Jan 2010 22:25:17 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Sat, 23 Jan 2010 22:25:17 GMT
Message-Id: <201001232225.o0NMPHaE031052@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 173596 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2010 22:25:17 -0000

http://p4web.freebsd.org/chv.cgi?CH=173596

Change 173596 by rwatson@rwatson_cinnamon on 2010/01/23 22:25:15

	Don't allow VOP_SETATTR() on fdescfs -- we could build up a capability
	rights mask for the operations it represents, but it actually isn't very
	coherent conceptually.  For example, you can chmod /dev/fd/X if that fd
	refers to a file, but if you stat() you don't see the file's mode.

Affected files ...

.. //depot/projects/trustedbsd/capabilities/src/sys/fs/fdescfs/fdesc_vnops.c#8 edit

Differences ...

==== //depot/projects/trustedbsd/capabilities/src/sys/fs/fdescfs/fdesc_vnops.c#8 (text+ko) ====

@@ -391,6 +391,8 @@
 		struct ucred *a_cred;
 	} */ *ap;
 {
+
+#if 0
 	struct vnode *vp = ap->a_vp;
 	struct vattr *vap = ap->a_vap;
 
@@ -430,6 +432,9 @@
 
 	vp->v_type = vap->va_type;
 	return (0);
+#else
+	return (EOPNOTSUPP);
+#endif
 }
 
 static int