From owner-freebsd-ports-bugs@freebsd.org Mon Apr 9 11:40:10 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAE85F9C648 for ; Mon, 9 Apr 2018 11:40:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 90E8F7E7B9 for ; Mon, 9 Apr 2018 11:40:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 48356F9C641; Mon, 9 Apr 2018 11:40:09 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0DC88F9C640 for ; Mon, 9 Apr 2018 11:40:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 90F747E789 for ; Mon, 9 Apr 2018 11:40:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 762AC241E8 for ; Mon, 9 Apr 2018 11:40:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w39Be7X8041628 for ; Mon, 9 Apr 2018 11:40:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w39Be7bq041627 for ports-bugs@FreeBSD.org; Mon, 9 Apr 2018 11:40:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227387] Mk/bsd.port.mk: Try to fix make clean for non-flavored dependency Date: Mon, 09 Apr 2018 11:40:07 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: loader@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 11:40:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227387 --- Comment #2 from Fukang Chen --- Sure. Thanks koobs@. FLAVOR=3Dpy27 is passed to the dependency ftp/curl through env: https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D466532&view= =3Dmarkup#l3814 3813 limited-clean-depends-${_f}: 3814 @cd ${.CURDIR} && ${SETENV} FLAVOR=3D${_f} ${MAKE} limited-clean-depends 3815 .endif then ${WRKDIR} turns to be /usr/ports/ftp/curl/work-py27 when it reaches he= re: https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D466532&view= =3Dmarkup#l1663 1663 .if empty(FLAVOR) 1664 _WRKDIR=3D work 1665 .else 1666 _WRKDIR=3D work-${FLAVOR} 1667 .endif 1668=20=20=20=20 1669 WRKDIR?=3D ${WRKDIRPREFIX}${.CURDIR}/${_WRKDIR} The first "=3D=3D=3D> Cleaning for curl-7.59.0" is executed by the pre-clean-noflavor: target: https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D466532&view= =3Dmarkup#l3789 3789 pre-clean-noflavor: 3790 @cd ${.CURDIR} && ${SETENV} ${MAKE} pre-clean 3791 .endif The Second "=3D=3D=3D> Cleaning for curl-7.59.0" is excuted by the pre-cle= an-py27: target: https://svnweb.freebsd.org/ports/head/Mk/bsd.port.mk?revision=3D466532&view= =3Dmarkup#l3818 3818 pre-clean-${_f}: 3819 @cd ${.CURDIR} && ${SETENV} FLAVOR=3D${_f} ${MAKE} pre-clean 3820 .endif Current behaviour: # cd /usr/ports/ftp/py-pycurl # make -C /usr/ports/ftp/curl BATCH=3D1 extract =3D=3D=3D> License MIT accepted by the user =3D=3D=3D> curl-7.59.0 depends on file: /usr/local/sbin/pkg - found =3D=3D=3D> Fetching all distfiles required by curl-7.59.0 for building =3D=3D=3D> Extracting for curl-7.59.0 =3D> SHA256 Checksum OK for curl-7.59.0.tar.xz. # make clean =3D=3D=3D> Cleaning for curl-7.59.0 =3D=3D=3D> Cleaning for curl-7.59.0 =3D=3D=3D> Cleaning for py27-pycurl-7.43.0.1 =3D=3D=3D> Cleaning for curl-7.59.0 =3D=3D=3D> Cleaning for curl-7.59.0 =3D=3D=3D> Cleaning for py36-pycurl-7.43.0.1 # test -d /usr/ports/ftp/curl/work ; echo $? 0 Expected behaviour (with patch): # cd /usr/ports/ftp/py-pycurl # make -C /usr/ports/ftp/curl BATCH=3D1 extract =3D=3D=3D> License MIT accepted by the user =3D=3D=3D> curl-7.59.0 depends on file: /usr/local/sbin/pkg - found =3D=3D=3D> Fetching all distfiles required by curl-7.59.0 for building =3D=3D=3D> Extracting for curl-7.59.0 =3D> SHA256 Checksum OK for curl-7.59.0.tar.xz. # make clean =3D=3D=3D> Cleaning for curl-7.59.0 =3D=3D=3D> Cleaning for py27-pycurl-7.43.0.1 =3D=3D=3D> Cleaning for py36-pycurl-7.43.0.1 # test -d /usr/ports/ftp/curl/work ; echo $? 1 --=20 You are receiving this mail because: You are on the CC list for the bug.=