From owner-freebsd-current@FreeBSD.ORG Mon Oct 20 08:14:14 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 81C72106566B for ; Mon, 20 Oct 2008 08:14:14 +0000 (UTC) (envelope-from ianf@clue.co.za) Received: from munchkin.clue.co.za (munchkin.clue.co.za [66.219.59.160]) by mx1.freebsd.org (Postfix) with ESMTP id 396878FC1A for ; Mon, 20 Oct 2008 08:14:14 +0000 (UTC) (envelope-from ianf@clue.co.za) DomainKey-Signature: a=rsa-sha1; q=dns; c=simple; s=20070313; d=clue.co.za; h=Received:Received:Received:X-Mailer:cc:From:Subject:In-Reply-To:References:X-Attribution:Mime-Version:Content-Type:Date:Message-Id; b=pcbcACW4tvF2vHnSjkQbAcR80AZ4laQQZlUtwf0uIx8tTfTuj0V09arWfVRbKaoB+yJm1fZCsGTCPJIzY2MzuTLkp8I796ZO5eK+8SFUM4LngPro5ygrpiiC1prRpUXaSBthQ6Big4wFvtwEG9Kf4HEBIYuZt6qu2MYhBLyrlZcxqIINKBX8JV8vxLJwvN4Cdaim6Ky8HusWA4p33YeiLd3ijX1zWuhOCFRbwaAAl660QaQGDEcNKvwNI858RXIV; Received: from uucp by munchkin.clue.co.za with local-rmail (Exim 4.67) (envelope-from ) id 1KrpuC-0005S0-DO for current@freebsd.org; Mon, 20 Oct 2008 08:14:24 +0000 Received: from ianf.clue.co.za ([10.0.0.6] helo=clue.co.za) by urchin.clue.co.za with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1KrptG-0006yb-16 for current@freebsd.org; Mon, 20 Oct 2008 08:13:26 +0000 Received: from localhost ([127.0.0.1] helo=clue.co.za) by clue.co.za with esmtp (Exim 4.69 (FreeBSD)) (envelope-from ) id 1KrptF-0001Tx-EQ for current@freebsd.org; Mon, 20 Oct 2008 10:13:25 +0200 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 From: Ian FREISLICH In-Reply-To: References: X-Attribution: BOFH Mime-Version: 1.0 Content-Type: multipart/mixed ; boundary="==_Exmh_1224490380_13100" Date: Mon, 20 Oct 2008 10:13:25 +0200 Message-Id: Cc: current@freebsd.org Subject: Re: PATCH: vinvalbuf(9), fusefs-kmod X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Oct 2008 08:14:14 -0000 This is a multipart MIME message. --==_Exmh_1224490380_13100 Content-Type: text/plain; charset=us-ascii "Ian Freislich" wrote: > Hi > > It appears that vinvalbuf() has changed, but the manual page has > not been updated. Also, after this change, sysutils/fusefs-kmod > doesn't compile. These patches address both issues. FFS. This list keeps on stripping attachments. Ian -- Ian Freislich --==_Exmh_1224490380_13100 Content-Type: text/plain ; name="vinvalbuf.9.patch"; charset=us-ascii Content-Description: vinvalbuf.9.patch Content-Disposition: attachment; filename="vinvalbuf.9.patch" Index: vinvalbuf.9 =================================================================== RCS file: /home/ncvs/src/share/man/man9/vinvalbuf.9,v retrieving revision 1.8 diff -u -d -r1.8 vinvalbuf.9 --- vinvalbuf.9 28 Jun 2005 20:15:18 -0000 1.8 +++ vinvalbuf.9 20 Oct 2008 07:46:47 -0000 @@ -36,7 +36,7 @@ .In sys/param.h .In sys/vnode.h .Ft int -.Fn vinvalbuf "struct vnode *vp" "int flags" "struct ucred *cred" "struct thread *td" "int slpflag" "int slptimeo" +.Fn vinvalbuf "struct vnode *vp" "int flags" "int slpflag" "int slptimeo" .Sh DESCRIPTION The .Fn vinvalbuf @@ -56,14 +56,6 @@ The only supported flag is .Dv V_SAVE and it indicates that dirty buffers should be synced with the disk. -.It Fa cred -The user credentials that are used to -.Xr VOP_FSYNC 9 -buffers if -.Dv V_SAVE -is set. -.It Fa td -The thread responsible for this call. .It Fa slpflag The slp flag that will be used in the priority of any sleeps in the function. .It Fa slptimeo --==_Exmh_1224490380_13100 Content-Type: text/plain ; name="fusefs-kmod.patch"; charset=us-ascii Content-Description: fusefs-kmod.patch Content-Disposition: attachment; filename="fusefs-kmod.patch" Index: files/patch-fuse_module__fuse_vnops.c =================================================================== RCS file: /home/ncvs/ports/sysutils/fusefs-kmod/files/patch-fuse_module__fuse_vnops.c,v retrieving revision 1.1 diff -u -d -r1.1 patch-fuse_module__fuse_vnops.c --- files/patch-fuse_module__fuse_vnops.c 26 Sep 2008 18:26:35 -0000 1.1 +++ files/patch-fuse_module__fuse_vnops.c 20 Oct 2008 08:03:53 -0000 @@ -1,5 +1,5 @@ ---- fuse_module/fuse_vnops.c.orig 2008-09-26 13:08:03.000000000 -0400 -+++ fuse_module/fuse_vnops.c 2008-09-26 13:14:36.000000000 -0400 +--- fuse_module/fuse_vnops.c.orig 2008-02-05 07:25:57.000000000 +0200 ++++ fuse_module/fuse_vnops.c 2008-10-20 10:02:22.000000000 +0200 @@ -799,8 +799,11 @@ struct vnode *vp = ap->a_vp; struct vattr *vap = ap->a_vap; @@ -26,6 +26,15 @@ if (err) return (err); facp->facc_flags |= FACCESS_VA_VALID; +@@ -1929,7 +1936,7 @@ + * It will not invalidate pages which are dirty, locked, under + * writeback or mapped into pagetables.") + */ +- err = vinvalbuf(vp, 0, td, PCATCH, 0); ++ err = vinvalbuf(vp, 0, PCATCH, 0); + fufh->flags |= FOPEN_KEEP_CACHE; + } + @@ -3005,8 +3012,11 @@ struct vattr *vap = ap->a_vap; struct vnode *vp = ap->a_vp; --==_Exmh_1224490380_13100--