From owner-p4-projects@FreeBSD.ORG  Sat Nov 19 12:29:59 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 471D616A421; Sat, 19 Nov 2005 12:29:59 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 09D4416A41F
	for <perforce@freebsd.org>; Sat, 19 Nov 2005 12:29:59 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C4E7C43D45
	for <perforce@freebsd.org>; Sat, 19 Nov 2005 12:29:58 +0000 (GMT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jAJCTw1X097707
	for <perforce@freebsd.org>; Sat, 19 Nov 2005 12:29:58 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jAJCTwIG097704
	for perforce@freebsd.org; Sat, 19 Nov 2005 12:29:58 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Sat, 19 Nov 2005 12:29:58 GMT
Message-Id: <200511191229.jAJCTwIG097704@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 86951 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Nov 2005 12:30:00 -0000

http://perforce.freebsd.org/chv.cgi?CH=86951

Change 86951 by rwatson@rwatson_peppercorn on 2005/11/19 12:29:08

	Annotate two cases where additional argument auditing may be
	desired for process group and session identifier information.

Affected files ...

.. //depot/projects/trustedbsd/audit3/sys/kern/kern_prot.c#5 edit

Differences ...

==== //depot/projects/trustedbsd/audit3/sys/kern/kern_prot.c#5 (text+ko) ====

@@ -351,6 +351,10 @@
 		newsess = NULL;
 	}
 
+	/*
+	 * XXXAUDIT: Audit the new session and process group ID's?
+	 */
+
 	sx_xunlock(&proctree_lock);
 
 	if (newpgrp != NULL)
@@ -396,6 +400,10 @@
 	if (uap->pgid < 0)
 		return (EINVAL);
 
+	/*
+	 * XXXAUDIT: Audit the joined process group ID?
+	 */
+
 	error = 0;
 
 	MALLOC(newpgrp, struct pgrp *, sizeof(struct pgrp), M_PGRP, M_WAITOK | M_ZERO);