From owner-freebsd-net Mon Oct 14 13:15:37 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A300737B401 for ; Mon, 14 Oct 2002 13:15:36 -0700 (PDT) Received: from mail.speakeasy.net (mail15.speakeasy.net [216.254.0.215]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4276043EB2 for ; Mon, 14 Oct 2002 13:15:36 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 4088 invoked from network); 14 Oct 2002 20:15:29 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail15.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 14 Oct 2002 20:15:29 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id g9EKFBn5032068 for ; Mon, 14 Oct 2002 16:15:14 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Date: Mon, 14 Oct 2002 16:15:12 -0400 (EDT) From: John Baldwin To: net@FreeBSD.org Subject: Rename of MSIZE kernel option.. Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Would people be open to renaming the 'MSIZE' kernel option to something more specific such as 'MBUF_SIZE' or 'MBUFSIZE'? Using 'MSIZE' can break other places in the kernel. For example, ISA device ivars have an ivar for the size of a memory resource called 'MSIZE' and the kernel option causes breakage in src/sys/isa/isavar.h: ISA_ACCESSOR(msize, MSIZE, int) when ISA_ACCESSOR is properly defined via __BUS_ACCESSOR() rather than homerolling a private copy of __BUS_ACCESSOR(). For now I've fixed it to rename the ISA ivar to ISA_IVAR_MEMSIZE but MSIZE seems to be too generic a name for a kernel option and it would be nice to avoid this problem in the future. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message