From owner-svn-src-head@FreeBSD.ORG Tue May 4 14:46:06 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 349121065672; Tue, 4 May 2010 14:46:06 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id B31C08FC1D; Tue, 4 May 2010 14:46:05 +0000 (UTC) Received: from outgoing.leidinger.net (pD9E2D0FC.dip.t-dialin.net [217.226.208.252]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 5AAB4844217; Tue, 4 May 2010 16:45:59 +0200 (CEST) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 26018507A; Tue, 4 May 2010 16:45:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1272984355; bh=V1wShdoR41gHTz76EoaQzP70CBUZhTd1SWIhEAR/JZs=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=syRfCizkiyXaqNabogZnzDMZGYt/HYmnPqz56J/EjzXt1vtenr7VXjKAqOC1mGilp 9ck5kOOS7IAPSzQZZ0wzQ6ulY0ABBFODHnjxatmv5UKxqQpLjgHv2cc8/J8q0ZdkG+ 4XWm1gLqBCjXr9oP9p02tGyqOweFzzMeZ0Ye/RwdQCRp25wagtaYZ7owcSzRdl6pIp gvVFztRimkETAMz/CwlPnBXZD7sI4AIzkbk5G3V0qipsexAONLoVmDkTLimNiUjH77 zTuVz2tUbyO0ofEezUruVgD4WwM7DSbw49WpeugLVVLpTRAm8ZKgj0qDNtOqHd/Kp5 5xjdsEfAN63JQ== Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id o44Ejsi0004690; Tue, 4 May 2010 16:45:54 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Tue, 04 May 2010 16:45:53 +0200 Message-ID: <20100504164553.55334ng6l4o6afms@webmail.leidinger.net> Date: Tue, 04 May 2010 16:45:53 +0200 From: Alexander Leidinger To: Norikatsu Shigemura References: <201005041125.o44BP5eW098015@svn.freebsd.org> <20100504160255.83302gi3jcftvoys@webmail.leidinger.net> <20100504232246.4a29424f.nork@FreeBSD.org> In-Reply-To: <20100504232246.4a29424f.nork@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 5AAB4844217.B32D4 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.363, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00, TW_SV 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1273589160.95797@y1XUcf1phRFoooAjBkRKlA X-EBL-Spam-Status: No Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, dougb@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r207612 - head/usr.sbin/mergemaster X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2010 14:46:06 -0000 Quoting Norikatsu Shigemura (from Tue, 4 May 2010 23:22:46 +0900): > Hi netchild. > > On Tue, 04 May 2010 16:02:55 +0200 > Alexander Leidinger wrote: >> > URL: http://svn.freebsd.org/changeset/base/207612 >> > Log: >> > Add support run services_mkdb(8). >> Shouldn't this (and similar messages) only be done if there is a >> corresponding DB file? >> Everything is working just fine without the DB files, and the >> man-pages only recommend to create DB files for performance reasons. >> By default the DB files are not created, and as such it looks a bit >> strange to tell to "make sure" to create the DB file(s). > > My first patch has a test code '[ -f /var/db/services.db ] &&', > However, as the result, I discussed with dougb, he said that > existing /var/db/services.db is harmless. So I don't have any > objection, and remove a test code. I do not complain about your patch, you just had the bad luck that I noticed an extension of something which I think is not user friendly. I just used your commit to tell Doug (and others) about it. I would print such a message only (for login.conf, services or whatever), if the DB file exists. Because if it exists, not updating the DB file is harmful (it does not contain what people would expect). If the file does not exist, there is nothing to do. The user does not want or does not know how to use this feature, so do not tell him to do or use something he doesn't want or doesn't understand (lack of knowledge, not lack of capability). Bye, Alexander. -- Sometime in 1993 NANCY SINATRA will lead a BLOODLESS COUP on GUAM!! http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137