From nobody Mon Aug 28 02:34:47 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RYvm0500xz4rw56 for ; Mon, 28 Aug 2023 02:34:56 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RYvm03VNhz4DWj; Mon, 28 Aug 2023 02:34:56 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693190096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uh4QQUhGP9DKSas+VpypAIvX3PMp6q4PVdbzMS5ZBN8=; b=XazI6fb4FkRytJBIju4PHQTsVtdhK8AYrYvdkIjNjeDzWp1rMrGBcnR8P2DOhZR9BTU6ew uXwT4bGMl9Il1Uo+byyix8RR636/6ooc4/TJcTVc25VaY2buE08jIsxT+wic04HI76fOKq 0KwmiNxnQL9waTRI1hNoqAmMOcBgoQgEgxyNz2O0KHi9MHVsHpg+msMPW7U+QC8hofcnKU S3tW/jBrh5nHUGzyR0afjsPRkcprYs16++Yzj0OfqQmIiJagX/fYqMpFlT5iV025AIanbl 5p5tAuK9CqR6Uh0TxEvGa2SavS2WYRz8t8/9dR6EiLwBdd4Uda3Cj3bZCbU05w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693190096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uh4QQUhGP9DKSas+VpypAIvX3PMp6q4PVdbzMS5ZBN8=; b=ADI1Zp3ydtOa3B9j3GhJpElP7zQbQRu0ued9OPA+rLKTF5qA5gXWT9zWEARvi8+K1zZiCg e+ubmperY0Rsu0A33viQCLydAC4pGkzQOyFczD2fsb2GgXFhk9Bqrbt+mi5c/AA1OQPe3z B16oGcLOtPGdLk8JuUBU4fn/eudWDmahyF0qShWb93lgi1+orJBxiy+3OPCcEsvJngYJSa sb9o2Q4kBW3k0oS11U7L1mmR/vbf+syup6brzqk3V381X49asH3Zo/pryDAqBbN+CsTDf2 era/VydtHLhHnve7EiW1zvHLIEanqGxCJA8rIUjI70WsejknxIWTa/gAPSoIvw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693190096; a=rsa-sha256; cv=none; b=ct8EwqJj1qp2k33vxOOwCgi9sg399SkhBlKZVG0se6tElMD73FUw2T07SAWMbNYg6C1D2k qNwTv54A4NYbh6MM70oU/j7QEWqIAutttTQxiA5BXKn1N0YL9jSZkGfVQCmvFf9uZegvbV OTXso21Bfr8qoiCspF34gVWuXZL5G+CYJFVa6DVc2VN2eHZhYjWpd7gZLC7k3QszuE+LfE 2pwObIhkJp5fgYY0BS7lnoYLhTv9kqC9fuActe9HyXiORX87Yn+3ssmMv4bi1k5ylpBJmR y1VhYi5lhK9gc8UOXzmoqfFn3vV/QQPId9XJK4iDUQVuD6BdQcA6GfcVhGdpuw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RYvly4tyMz1bbZ; Mon, 28 Aug 2023 02:34:54 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Message-Id: <8BA46336-3E51-42E7-BD95-CA3A44B9E623@FreeBSD.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_55D912F6-199E-4A8F-8E91-B293242E36A3" List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: Question about KBI change / new feature Date: Mon, 28 Aug 2023 10:34:47 +0800 In-Reply-To: Cc: FreeBSD CURRENT To: Warner Losh References: X-Mailer: Apple Mail (2.3696.120.41.1.4) --Apple-Mail=_55D912F6-199E-4A8F-8E91-B293242E36A3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 23, 2023, at 1:06 AM, Warner Losh wrote: >=20 >=20 >=20 > On Mon, Aug 21, 2023 at 9:42=E2=80=AFAM Zhenlei Huang = > wrote: > Hi, >=20 > The https://www.freebsd.org/releases/14.0R/schedule/ = says CURRENT/14 's = KBI is froze > and new features should be avoided. >=20 > I'm working on https://reviews.freebsd.org/D39638 = (sysctl(9): Enable vnet sysctl = variables be loader tunable) > and I think it is new feature, but not quite sure whether the KBI = changed. >=20 > So, >=20 > 1. Is it a KBI change ? >=20 > IMHO, It's a KPI change, not a KBI breakage. So from that perspective, = it's OK. Thanks for the explanation ! > =20 > 2. It is a simple change ( while so far as I know currently only = tested by myself on x86 and qemu riscv ), can > it catch up with 14 ? >=20 > That I'm less sure of. I think it's good, but I'm gun shy about = approving / committing vnet things. The review suggests, > though, there's at least some consensus for having this in the tree. I always hesitate to PING someone to review ;) Well I'm going to prepare to commit some of the stack, D41525, D39638, = D39852, D39866, if no objections. As for D40127, I have mixed filling about it. It might be too complex = (for a simple function). I wonder if we can have per-vnet `loader tunnable` to archive the same = goal. Best regards, Zhenlei --Apple-Mail=_55D912F6-199E-4A8F-8E91-B293242E36A3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Aug 23, 2023, at 1:06 AM, Warner Losh <imp@bsdimp.com> = wrote:



On Mon, Aug 21, 2023 at 9:42=E2=80=AFAM = Zhenlei Huang <zlei@freebsd.org> wrote:
Hi,

The https://www.freebsd.org/releases/14.0R/schedule/ says = CURRENT/14 's KBI is froze
and new features should be avoided.

I'm working on https://reviews.freebsd.org/D39638 (sysctl(9): Enable = vnet sysctl variables be loader tunable)
and I think it is new feature, but not quite sure whether the KBI = changed.

So,

1. Is it a KBI change ?

IMHO, It's a KPI change, not a KBI = breakage. So from that perspective, it's = OK.

Thanks for the explanation !

 
2. It is a simple change ( while so far as I know currently only tested = by myself on x86 and qemu riscv ), can
it catch up with 14 ?

That I'm less sure of. I think it's = good, but I'm gun shy about approving / committing vnet things. The = review suggests,
though, there's at least some = consensus for having this in the = tree.

I= always hesitate to PING someone to review ;)

Well I'm going to prepare to commit some of the = stack, D41525, D39638, D39852, D39866, if no = objections.

As for D40127, I = have mixed filling about it. It might be too complex (for a simple = function).
I wonder if we can have per-vnet `loader tunnable` = to archive the same goal.

Best regards,
Zhenlei

= --Apple-Mail=_55D912F6-199E-4A8F-8E91-B293242E36A3--