From owner-freebsd-arch@freebsd.org Thu Sep 28 16:49:12 2017 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF18CE0391E for ; Thu, 28 Sep 2017 16:49:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 930FF65A75 for ; Thu, 28 Sep 2017 16:49:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x242.google.com with SMTP id j26so1303529iod.0 for ; Thu, 28 Sep 2017 09:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=oRCTxRm4z83OWzgr7OIPeEYpMHbT81cjwqo+ciCKfrs=; b=N+evWcS03RKq024bQQB9hfsKNT/mbOyx54yR6gXacqTUC2mkHfiw2tP3A7IzLYbvRI UnNFkBXxVx3GTn9ypZcigQj51YhfVdO+h5NFp8Hih0JowX37xnqivJi/GMFHALXC8YEv UMJxnJij73KBwIbiYQ9drtkGSzJPOTekeBcVHfBct+HJIIbXMQQ4FZUBaBt7faKo9nLo 7g9dIWH0Q4C1znHGHXLng3GJHhmDji8OsRmIPIS6ZvaLfmf/y3BuSiSnpWFN6Gnf3ib2 AkA6KUENZCYPD6fDYst09kFS2k9T9oOh7FUqQtWQLT66GTbW303IUhoBBippSIx1JsQ/ Xa5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=oRCTxRm4z83OWzgr7OIPeEYpMHbT81cjwqo+ciCKfrs=; b=VMH53C6UNPh2qcpqY8ts7KQ4E90eFaomy+kN7jIViZCx4czYyMYQgjzOwuANJe7BHj fvB91hVimgoGAqDgp15lvRC2ton+h4Hkt9696ZO3pxilDrpCcT9RbVu8HCbdyA592fxU BS8BuQkxaXNSVNGzVj44mF613cJVPU4WJKqjXK8z85k+5Gw0HQSWdvBSO35iXFSfkuMp 8VF5lvSBkkvG7fqG52+o1hPuEF5Z6Pl+TftoODu2D0bI3zGeS2Rz5/jtS4JVwWXPyh4g k/LjvZeQF/R6MuKjhSVbTRnamuZD+tBZVqeil+9uGYvSTeLz55VUByWZ5Va5HOxJMMcc L0Kw== X-Gm-Message-State: AMCzsaVbc7OV5+lD+1+p4TRihGoV0Qo3Z1LODpjNy41GCuA3ckM5XGu2 OHo8MyYaIOTlcAc45k6Kh8b2F7I7qUFBiJwU6K8Ytg== X-Google-Smtp-Source: AOwi7QB99+CGZRlI2//OHQfJO0Zu5YTprwXKbNoeBvl2W4Zy8u15tkKc15mYimAuuBsP1m0jxl+G4U/Ac4YigolpWA0= X-Received: by 10.107.7.161 with SMTP id g33mr7922128ioi.169.1506617351805; Thu, 28 Sep 2017 09:49:11 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.2.194 with HTTP; Thu, 28 Sep 2017 09:49:11 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:f996:822c:89a6:8ee4] In-Reply-To: <64f6d438-e985-9262-2b1d-1e4b017b7691@FreeBSD.org> References: <64f6d438-e985-9262-2b1d-1e4b017b7691@FreeBSD.org> From: Warner Losh Date: Thu, 28 Sep 2017 10:49:11 -0600 X-Google-Sender-Auth: pbzLQWtqyj9Xu_CJ-oBSlWwgVos Message-ID: Subject: Re: lua in zfs To: Andriy Gapon Cc: "freebsd-arch@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 16:49:12 -0000 On Thu, Sep 28, 2017 at 10:42 AM, Andriy Gapon wrote: > On 28/09/2017 18:40, Warner Losh wrote: > > > > > > On Thu, Sep 28, 2017 at 9:16 AM, Andriy Gapon > > wrote: > > > > On 28/09/2017 16:13, Warner Losh wrote: > > > Which version? Where in the tree? Can this be disabled? > > > > It's lua 5.2.4 at the moment. Its source code will reside in > > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/lua. At run-time it > will be in > > zfs.ko or in kernel if it's built with ZFS option. For time being, > it's not > > possible to turn it off individually, but if you don't include ZFS > or any CDDL > > licensed code at all, then you won't have Lua too. But I think that > it should > > be possible to add a new knob specifically to compile ZFS without > Lua, if > > anybody wants it. > > > > > > OK. Any chance you could put it in sys/contrib/lua instead? The same > place that > > the boot loader lua project has it? The lua boot loader project is using > 5.3.0 > > it seems, is there any reason you couldn't use that instead? > > I don't really know. I am just importing an upstream ZFS commit, because > without it we are getting more and more out of sync. I don't know if the > ZFS > Lua has any special customizations, etc. I don't want to spend a lot of > time on > investigating that and fighting with any possible quirks. If the > consolidation > of Lua-s is possible and practical, then I hope that someone will do it. > > Of course, there is another option which is not to import any Lua at all > right > now and to stub out all calls into Lua-dependent routines with ENOTSUP. > In that > case we will have plenty of time to work on importing a perfect Lua. On > the > other hand, switching from one Lua to another and doing svn rm is not hard > either. I'm happy to work with you on this. I'd like to get lua bootloader into the tree, and this gives me motivation to finish it up, even if it is a bit rough around the edges... What's your timeline for bringing this stuff in? Warner > > > I've been working on this in the background and was hoping to get it in > before 12. > > > > > On Thu, Sep 28, 2017 at 5:40 AM, Andriy Gapon > > wrote: > > > > > >> > > >> I am going to import the upstream ZFS Channel Programs change > that adds Lua > > >> interpreter to ZFS kernel code. In addition to pure Lua (no > libraries) it > > >> also > > >> has a number of functions to interact with ZFS. No general > purpose kernel > > >> access. > > > -- > Andriy Gapon >