From owner-dev-commits-ports-all@freebsd.org Fri Oct 1 11:57:39 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 916716AD9B1; Fri, 1 Oct 2021 11:57:39 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from mail.anongoth.pl (mail.anongoth.pl [46.248.190.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X448 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "anongoth.pl", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HLTBV50cYz3qTl; Fri, 1 Oct 2021 11:57:38 +0000 (UTC) (envelope-from pkubaj@anongoth.pl) Received: from anongoth.pl (unknown [192.168.1.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: pkubaj@anongoth.pl) by mail.anongoth.pl (Postfix) with ESMTPSA id 4D3B7EDFE8; Fri, 1 Oct 2021 13:57:34 +0200 (CEST) Date: Fri, 1 Oct 2021 13:57:32 +0200 From: Piotr Kubaj To: Jan Beich Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64* Message-ID: References: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fYWMURoXTPITeQXf" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4HLTBV50cYz3qTl X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.40 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEFALL_USER(0.00)[pkubaj]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; MID_RHS_NOT_FQDN(0.50)[]; ARC_NA(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:46.248.190.61]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[anongoth.pl,reject]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:47544, ipnet:46.248.160.0/19, country:PL]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[dev-commits-ports-all,dev-commits-ports-main] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Oct 2021 11:57:39 -0000 --fYWMURoXTPITeQXf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable https://github.com/libjxl/libjxl/issues/677 On 21-10-01 09:24:31, Jan Beich wrote: > Piotr Kubaj writes: >=20 > > On 21-09-30 21:50:21, Jan Beich wrote: > >> Piotr Kubaj writes: > >>=20 > >> > The include in cpu.cc is not actually necessary, so I did not in= clude anything for FreeBSD. > >> [...] > >> > +--- tools/cpu/cpu.cc.orig 2021-09-30 15:38:45 UTC > >> > ++++ tools/cpu/cpu.cc > >> > +@@ -19,7 +19,9 @@ > >> > + #endif > >> > +=20 > >> > + #if JXL_ARCH_PPC > >> > +-#include // __ppc_get_timebase_freq > >> > ++#if linux > >> > ++#include // NOLINT __ppc_get_timebase_freq > >> > ++#endif > >> > + #endif > >>=20 > >> Can you file a bug via https://github.com/libjxl/libjxl/issues/new ? > >> That include is probably unused even on Linux after 5175d11717f3 > >> removed __ppc_get_timebase_freq. > >>=20 > >> Note, if you can't sign Google CLA don't submit a fix. Otherwise, upst= ream > >> will refuse to read the rationale (PR description), let alone the patc= h e.g., > >> https://github.com/libjxl/libjxl/pull/193 > > > > No, I don't have a Google account. >=20 > It's not necessary for filing a bug. Doing so on your behalf is > complicated by not having powerpc64 hardware to verify fixes proposed > upstream and not having an error log/excerpt for upstream to better > understand what needs to be changed. >=20 > Outside of CLA upstream is very helpful. FreeBSD is officially supported > (see JXL_OS_FREEBSD) and fixed timely e.g., > https://gitlab.com/wg1/jpeg-xl/-/issues/65 > https://gitlab.com/wg1/jpeg-xl/-/issues/66 --=20 --fYWMURoXTPITeQXf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmFW96wACgkQelmbhSCD nJ1A/g//ULyL6uR8fJuo2jZIOTuhsIClOhCZYFrXACfAwuFCqylzdw3xidW2vHY0 j0mSe7QxPlcKgbw1f6O2f7e4yX3XcWGRgkg4HIw3pz5vSw68xerwLMCHQOi0nHB3 eKv10+FQzHaIPav651XSjVnX4qjnfUnZuScLyeGf5Lqj1dXDfMMrx7dRJlPJdSB+ 9ALBY4BUQdOan9+C0lTrBOfesq7ZhfGfhuQQKaj5ktzoVWBIvnmLyPCrb0ReiCDe KSKDMd06KnPNCJU8Dms9ylvKLKU2ZQTNaFyImPhxnAavn0s4kPfTFKo/qOyHDBUs P37Co+qO+N44J2qlx4H5XKEnWwm8Tbvm0C7Be4tOnGwhO5Grx3YVUJhgzMtktWJp RnwJE/pk68dxqlKG7BXfPn+2CzhNjAxk5qToSlsoJjlNVfhpOvyhwAxKF8E11dfQ I0DrO2FU5sATJ2nW9fdxI+iKyl73QeawVMYab2+nZre5Zu3XCmXfaDS0IvQSA6kh IC85fWmjKNeUe+fPOfGvmk4ZKZtdm7sHZd4LsSGr2E8FQy9npLFYRJi/bOyLqi0L /3niYVXigJAS73YCUsOHVbPLmty72zNONzUUFhsgkKRrZWqRV/8G17d1nujRZZ9l E240evkHFUQm+Bc2K4kOX2/5aI4IkSvml1yjNmyFiGNAEj6NcRg= =VPaz -----END PGP SIGNATURE----- --fYWMURoXTPITeQXf--