From nobody Sun May 3 18:48:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g7v1v4sBJz6bsJG for ; Sun, 03 May 2026 18:48:51 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g7v1v2TNgz3lbW for ; Sun, 03 May 2026 18:48:51 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4891f625344so34937265e9.0 for ; Sun, 03 May 2026 11:48:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777834130; x=1778438930; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ccFfxir9trlNsniLRapBXRh48nxUdv74CiuMMmVBcU4=; b=CVuLRB+ayxGFcc95Rzwgc7YwXGkxYNFpp5WRutCvjrSJKJnKsVwm0LytZqIg5X3A4N BVA/EmngkFcJgTS1Yj8WDhSju1kqLzocRsQlDkw1pBH6OUrzg7rxo4RDuFvfvAHbZNqe 4DIR68BgOobCucnKiRfIYRJk2xZc2rXPkM+I//n26CALfZb8INOTAhFWKA/2Bk2W26iS 1hdl7HOscxUjxqF66MBHogNGDELBWM4DmI8buHom3rJ9+cAxXkrmGfbefb6tv9m1/7HO QHrGvnPfib/e7Dsxhp1jVYbhlVB1ekg5EcUXeVOpZU13ufeDp+XJlldFRKq40AiWpjIT B40Q== X-Forwarded-Encrypted: i=1; AFNElJ/YYTVG8fOqQ/KwL+Z6lYLxelBW6LvUpWwFYJwj6ew87yJVlLfshK346O1f5i+ZYiuXXsVYLTHlaOFvGwNP2XTOmXF1@freebsd.org X-Gm-Message-State: AOJu0YxO3XWaizk+TKT1DEvdvfcBBG1pswC1CPGI/jlGx/8c+3Awr922 IsQGzkQC8V4vY0qZ9m+t4taS8ePZljoloSMUGyZgasLHHz7JiXf/xer8mJcrOFFb8K7tuaLbwvS /0H1FKak= X-Gm-Gg: AeBDiesPF084YsWVuciF8rk6rO7NvB0XQojTzv6KWMsFz6HQolQvftDRIBr9ZSzBVSE yr7iOEBBIFg4kAorlZ+CBH+DvIrIqZvV1PO93cgYIGuVNcIiZoux/oLRo61a+RYuZp2qgPL/+Re lkDqgsdQhKOAYgaHt1v1KR5EoVSn+NRpTU33pF27udw4F97QadqmT4WbN368W092dpHKV/TKtvx 971aDM0vtHUZE3bweF0P/OHDXQ9cNwlp2eOuhckZgx+4sIWtNIA+UzkT40yp9XVOhAMXDwA07Zq z/BXmchrKvdvmRPpoFOzwaleEG3r/kJA7H2LU5O/H0L3xcveSSzbqS9lEqeqmH+t0STUCZM+xsr uzpGFkMnjMTtv2qEdiefwf89n8YBuwxuCeSHDEtWotUU1zT71hPIGlwtvFmmN2VlBuFnOyXmucH WdRz2Tt1ywsUlqU4FGT72NkDZGUpxHW/5rgBT6kaPPUuGB/orDABeeL9BTUQKl9zetVa9tiJQ/R bNXxaE7B844iQ== X-Received: by 2002:a05:600c:26d2:b0:48a:5236:7f38 with SMTP id 5b1f17b1804b1-48a8607970fmr142754895e9.14.1777834129280; Sun, 03 May 2026 11:48:49 -0700 (PDT) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a9879ef89sm23105541f8f.30.2026.05.03.11.48.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 May 2026 11:48:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: 01674e15dedb - main - bsd.endian.mk: Optimize the handling of big/little endian determination. From: Jessica Clarke In-Reply-To: <69f6b1ec.181e8.27d0b938@gitrepo.freebsd.org> Date: Sun, 3 May 2026 19:48:37 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <6C5FEC1A-D8E1-45B8-A80A-B32F81392058@freebsd.org> References: <69f6b1ec.181e8.27d0b938@gitrepo.freebsd.org> To: "Stephen J. Kiernan" X-Mailer: Apple Mail (2.3864.400.21) X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g7v1v2TNgz3lbW X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated On 3 May 2026, at 03:24, Stephen J. Kiernan wrote: >=20 > The branch main has been updated by stevek: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D01674e15dedb15f8ce498af0680c50bb= 075c5482 >=20 > commit 01674e15dedb15f8ce498af0680c50bb075c5482 > Author: Stephen J. Kiernan > AuthorDate: 2024-04-03 23:25:19 +0000 > Commit: Stephen J. Kiernan > CommitDate: 2026-05-03 02:21:56 +0000 >=20 > bsd.endian.mk: Optimize the handling of big/little endian = determination. >=20 > Add variables to contain lists of MACHINE_ARCH values to use > to determine little or big endian. >=20 > Only error out about not being able to determine endianess if > TARGET_ENDIANNESS is empty and not cross-compiling. >=20 > Reviewed by: sjg > Obtained from: Hewlett Packard Enterprise Development LP > Differential Revision: https://reviews.freebsd.org/D44629 > --- > share/mk/bsd.endian.mk | 39 +++++++++++++++++++++++++++++---------- > 1 file changed, 29 insertions(+), 10 deletions(-) >=20 > diff --git a/share/mk/bsd.endian.mk b/share/mk/bsd.endian.mk > index 0c5ebb7aeba2..2a617a1d2794 100644 > --- a/share/mk/bsd.endian.mk > +++ b/share/mk/bsd.endian.mk > @@ -1,20 +1,35 @@ >=20 > -.if ${MACHINE_CPUARCH} =3D=3D "aarch64" || \ > - ${MACHINE_CPUARCH} =3D=3D "arm" || \ > - ${MACHINE_ARCH} =3D=3D "amd64" || \ > - ${MACHINE_ARCH} =3D=3D "i386" || \ > - ${MACHINE_ARCH} =3D=3D "powerpc64le" || \ > - ${MACHINE_CPUARCH} =3D=3D "riscv" Losing MACHINE_CPUARCH makes me sad as a downstream that adds new MACHINE_ARCH for aarch64 and riscv. For riscv at least it=E2=80=99s now = riscv* which I guess is close enough, but for aarch64 it=E2=80=99s not = wildcarded. Similarly arm though I don=E2=80=99t care about that personally. > +MACHINE_ARCH_LIST.little =3D \ > + aarch64 \ > + amd64 \ > + armv7 \ > + i386 \ > + powerpc64le \ > + riscv* > + > +MACHINE_ARCH_LIST.big =3D \ > + powerpc \ > + powerpc64 > + > +.for e in big little > +N_$e:=3D ${MACHINE_ARCH_LIST.$e:${M_ListToSkip}} Should we be worried about catching MACHINE(_ARCH) being empty? Jessica > +.endfor > + > +# For the host, we need to look at the host architecture > +.if ${MACHINE:Nhost*} =3D=3D "" > +_ENDIAN_ARCH=3D${_HOST_ARCH} > +.else > +_ENDIAN_ARCH=3D${MACHINE_ARCH} > +.endif > + > +.if ${_ENDIAN_ARCH:${N_little}} =3D=3D "" > TARGET_ENDIANNESS=3D 1234 > CAP_MKDB_ENDIAN=3D -l > LOCALEDEF_ENDIAN=3D -l > -.elif ${MACHINE_ARCH} =3D=3D "powerpc" || \ > - ${MACHINE_ARCH} =3D=3D "powerpc64" > +.elif ${_ENDIAN_ARCH:${N_big}} =3D=3D "" > TARGET_ENDIANNESS=3D 4321 > CAP_MKDB_ENDIAN=3D -b > LOCALEDEF_ENDIAN=3D -b > -.elif ${.MAKE.OS} =3D=3D "FreeBSD" > -.error Don't know the endian of this architecture > .else > # > # During bootstrapping on !FreeBSD OSes, we need to define some value. = Short of > @@ -33,3 +48,7 @@ TARGET_ENDIANNESS=3D 1234 > CAP_MKDB_ENDIAN=3D -B # Poisoned value, invalid flags for both = cap_mkdb > LOCALEDEF_ENDIAN=3D -B # and localedef. > .endif > + > +.if empty(TARGET_ENDIANNESS) && ${.MAKE.OS} =3D=3D "FreeBSD" > +.error Don't know the endianness of this architecture > +.endif >=20