From owner-freebsd-current@FreeBSD.ORG Mon Aug 2 14:48:09 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AA6716A4CE for ; Mon, 2 Aug 2004 14:48:09 +0000 (GMT) Received: from mproxy.gmail.com (rproxy.gmail.com [64.233.170.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1B23A43D2F for ; Mon, 2 Aug 2004 14:48:09 +0000 (GMT) (envelope-from dan.cojocar@gmail.com) Received: by mproxy.gmail.com with SMTP id 76so128547rnl for ; Mon, 02 Aug 2004 07:48:07 -0700 (PDT) Received: by 10.38.78.55 with SMTP id a55mr32513rnb; Mon, 02 Aug 2004 07:48:07 -0700 (PDT) Message-ID: Date: Mon, 2 Aug 2004 17:48:07 +0300 From: Dan Cojocar To: Max Laier In-Reply-To: <200408021508.43112.max@love2party.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit References: <200408021220.20785.max@love2party.net> <200408021508.43112.max@love2party.net> cc: freebsd-current@freebsd.org Subject: Re: Buildkernel+ALTQ error X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2004 14:48:09 -0000 On Mon, 2 Aug 2004 15:08:36 +0200, Max Laier wrote: > > > On Monday 02 August 2004 15:00, Dan Cojocar wrote: > > > Uhm, well ... attached diff should fix this, but I still think that your > > > build environment is somehow defective as the required headers would be > > > pulled in via the following - certainly discussable - include chain: > > > net/if.h -> _KERNEL => net/if_var.h -> altq/if_altq.h -> sys/lock.h & > > > mutex.h > > > > > > I have to clean that up and add lock headers where needed. Can you > > > meanwhile check out if that helps and/or if a #make installincludes > > > helps? Thanks. > > > > I just did a cvsup; make clean twice; make buildworld; make > > installincludes; make buildkernel and got the same error :( > > then installed you patch and make a build kernel and i got the same error > > :( > > > > What else could i try? > > Okay :( ... if you got the *exact* same error, I am out of ideas. If, however, > you get the same error on another file (e.g. altq_hfsc.c) than it's > understood and I have work to do ... please cross-check and sorry for the > noise. I am still wondering why I can't reproduce it and why none of the > tinderboxes is catching it. > I decided to build a kernel without altq, i removed altq from my config, did a rm -fR /usr/obj; buildworld, and on buildkernel i got this error: cc -c -O -pipe -march=athlon-xp -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- -I. -I/usr/src/sys -I/usr/src/sys/contrib/dev/acpica -I/usr/src/sys/contrib/altq -I/usr/src/sys/contrib/ipfilter -I/usr/src/sys/contrib/pf -I/usr/src/sys/contrib/dev/ath -I/usr/src/sys/contrib/dev/ath/freebsd -I/usr/src/sys/contrib/ngatm -D_KERNEL -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -ffreestanding -Werror /usr/src/sys/dev/ata/ata-all.c /usr/src/sys/dev/ata/ata-all.c: In function `ata_ioctl': /usr/src/sys/dev/ata/ata-all.c:536: warning: implicit declaration of function `_mtx_assert' /usr/src/sys/dev/ata/ata-all.c:536: warning: nested extern declaration of `_mtx_assert' /usr/src/sys/dev/ata/ata-all.c:536: error: `MA_NOTOWNED' undeclared (first use in this function) /usr/src/sys/dev/ata/ata-all.c:536: error: (Each undeclared identifier is reported only once /usr/src/sys/dev/ata/ata-all.c:536: error: for each function it appears in.) *** Error code 1 Now i think that is something wrong with my config, but i don't understant what :(, i'm using the same configuration for some time now and i didn't have errors like this. I will try make a clean cvsup in another dir maybe i will notice the differences. Thanks, Dan