From owner-freebsd-bugs@FreeBSD.ORG Tue Jan 13 13:50:25 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6E8916A4CF for ; Tue, 13 Jan 2004 13:50:25 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4DB743D54 for ; Tue, 13 Jan 2004 13:50:21 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0DLoLFR033810 for ; Tue, 13 Jan 2004 13:50:21 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0DLoLkg033809; Tue, 13 Jan 2004 13:50:21 -0800 (PST) (envelope-from gnats) Resent-Date: Tue, 13 Jan 2004 13:50:21 -0800 (PST) Resent-Message-Id: <200401132150.i0DLoLkg033809@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mike Hibler Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D7DD916A4CE for ; Tue, 13 Jan 2004 13:49:42 -0800 (PST) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 94D4743D55 for ; Tue, 13 Jan 2004 13:49:37 -0800 (PST) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i0DLnbdL036898 for ; Tue, 13 Jan 2004 13:49:37 -0800 (PST) (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.12.10/8.12.10/Submit) id i0DLnb7v036897; Tue, 13 Jan 2004 13:49:37 -0800 (PST) (envelope-from nobody) Message-Id: <200401132149.i0DLnb7v036897@www.freebsd.org> Date: Tue, 13 Jan 2004 13:49:37 -0800 (PST) From: Mike Hibler To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.0 Subject: misc/61336: traceroute doesn't work with more than 85 hops X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jan 2004 21:50:25 -0000 >Number: 61336 >Category: misc >Synopsis: traceroute doesn't work with more than 85 hops >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jan 13 13:50:21 PST 2004 >Closed-Date: >Last-Modified: >Originator: Mike Hibler >Release: 4.7-RELEASE >Organization: University of Utah >Environment: >Description: Any combination of (nhops * nprobes per hop) > 255 will fail due to a sequence number placed in the packet as 8-bits but kept internally as 32-bits. So comparison of what comes back in the packet (8-bits) with the internal counter (32-bits) fails. With the default of 3 probes per hop, 85 * 3 == 255. I know, I know, who gives a .... :-) >How-To-Repeat: Traceroute a host 86 hops away! >Fix: Ensure that the "check" performed upon reply only uses 8-bits of sequence, as the "prepare" function does implicitly by using outdata->seq 1060c1060 < && (*proto->check)((u_char *)icp,seq)) --- > && (*proto->check)((u_char *)icp, (u_char)seq)) 1072c1072 < && (*proto->check)(inner, seq)) --- > && (*proto->check)(inner, (u_char)seq)) >Release-Note: >Audit-Trail: >Unformatted: