From owner-cvs-src@FreeBSD.ORG Thu Nov 3 07:42:16 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E6C416A41F; Thu, 3 Nov 2005 07:42:16 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20DC843D46; Thu, 3 Nov 2005 07:42:16 +0000 (GMT) (envelope-from ps@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id jA37gFus056491; Thu, 3 Nov 2005 07:42:15 GMT (envelope-from ps@repoman.freebsd.org) Received: (from ps@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id jA37gFYk056490; Thu, 3 Nov 2005 07:42:15 GMT (envelope-from ps) Message-Id: <200511030742.jA37gFYk056490@repoman.freebsd.org> From: Paul Saab Date: Thu, 3 Nov 2005 07:42:15 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/nfsclient nfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2005 07:42:16 -0000 ps 2005-11-03 07:42:15 UTC FreeBSD src repository Modified files: sys/nfsclient nfs_vnops.c Log: In nfs_flush(), clear the NMODIFIED bit only if there are no dirty buffers *and* there are no buffers queued up for writing. The bug was that NMODIFIED was being cleared even while there were buffers scheduled to be written out, which leads to all sorts of interesting bugs - one where the file could shrink (because of a post-op getattr load, say) causing data in buffer(s) queued for write to be tossed, resulting in data corruption. Submitted by: Mohan Srinivasan Revision Changes Path 1.259 +2 -1 src/sys/nfsclient/nfs_vnops.c