From nobody Tue Nov 12 20:18:21 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XnyR24Lsxz5cXZv; Tue, 12 Nov 2024 20:18:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XnyR23qRzz46rt; Tue, 12 Nov 2024 20:18:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731442702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j+R7RRPz71piLnQNVkKMuLB0U/YQHnsOM+RhqiGgHCw=; b=O7OwmHoCa3O6MugxP3POiVWOF9+AEHSaAwbcXN0e8O8NJjVAahyXVtCsrTocp+Wa76Q6JV 9Lld2infj+vOj/hJBXXrFppdY0WUQMF3WlWwLDQtQ5LPs7T3X6CZgy4DFpxnro6Lq6DLWm 3BgJHzW4otsCrxWA3XzjcG2k+2joeu+GuJylr253CvIVPz0K74qSqccLhkajcdkskdkU90 MMh6fvHxXxV0l+i3W7kb09oquynU9XE6NGdsLAr/c5pvqlqChcEuTFS8vl9Ff1XZV9tsUM N9G568hyGTca+Y2PO1SthsE/8QZ5S65wCtPDR+k080mII+TOhYpcxXFJXNil2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731442702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j+R7RRPz71piLnQNVkKMuLB0U/YQHnsOM+RhqiGgHCw=; b=MxzRANuF3KLC7YQBY+4Eb5SE0Xju4DFwv7BsfIK5LPbEvlPWAyk+GMCdjgoaow9r0ym5br dSKw+WwlErH6DsnZyY4Mk1+BxyV54+4WdXQWp35+mu3AKrQ3HjLTqzG0dQOOVGmK5p9oIg FSKHcG3RtIK/pdCRmYT2akH7PHscvR0sdGnB4mt880CRsZGhuJLaiQGtU85cgaoc84nWRA SqY///oiQjUiajK8gX0legQUiYfEtdvH4LPe27f1rEU4madH248tC6UkZYsYijCHvU5259 seL203FNH4y/qomAxgoQyvghN2qvmOftKyEwgQE2rPJf73U6GypzGf7xdPlyWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731442702; a=rsa-sha256; cv=none; b=gpWsqFlD/V0kiFax+juOucYl3dJ99ysjtNDe+ZLTabSNBEL3DINSg7gNTpA3urwNBbOXsE ya8/9JCZSz8vTM8O8FkxuEzeyyZvhX0Hzngm+aec3VC4YN8w9lEmKnlMnPBTGfv6m+4paf qf6qcMS8NhrrWz+H2Gq59kInvKlEm6/LwFzF4k5pScdnSGaBvpFZ08sN8bw10gUOlivbmp oBBMrBzd9xDL/8qOhLBfdwrKKwLf8oQco70ZPytzJ8/8cBTEhEMLiZcVmWUNS9jJ1gMu8i l4mX6m5LqXz6uhhe95/OJRYNCJPU3pj92MGgp0bG+fJOnQZe7EfsvAyXkCBeQw== Received: from [IPV6:2601:5c0:4200:b830:2540:4129:cca:cf63] (unknown [IPv6:2601:5c0:4200:b830:2540:4129:cca:cf63]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XnyR21kl5z12DX; Tue, 12 Nov 2024 20:18:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 12 Nov 2024 15:18:21 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 1fa6daaafd74 - main - ipfilter: Avoid stopping with a lock held Content-Language: en-US To: jlduran@freebsd.org, Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202411120347.4AC3lPOA015167@gitrepo.freebsd.org> <09923ad3-4065-4a31-b35f-74f84e09cff1@FreeBSD.org> <20241112155219.2E15A2DF@slippy.cwsent.com> <20241112160243.B372532F@slippy.cwsent.com> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/12/24 10:35, Jose Luis Duran wrote: > What would be the recommended approach in this case? > Revert, and commit with the fixes, or just fix the problematic code. > > At any rate, I have created https://reviews.freebsd.org/D47530. Feel > free to commandeer it, as my testing is limited to what's currently in > the "Test Plan". I was not able to recreate the deadlock described > here, but it definitely makes sense. There is no deadlock in this case because it is recursing on a shared lock. FWIW, I think your review is fine, and I would have been ok with just committing that instead of reverting everything. -- John Baldwin