From owner-cvs-src@FreeBSD.ORG Wed Aug 17 17:10:40 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3849016A41F; Wed, 17 Aug 2005 17:10:40 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from haven.freebsd.dk (haven.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id D432443D45; Wed, 17 Aug 2005 17:10:39 +0000 (GMT) (envelope-from phk@phk.freebsd.dk) Received: from phk.freebsd.dk (unknown [192.168.48.2]) by haven.freebsd.dk (Postfix) with ESMTP id DFB9EBC66; Wed, 17 Aug 2005 17:10:37 +0000 (UTC) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 17 Aug 2005 10:04:37 PDT." <43036E25.6010508@root.org> Date: Wed, 17 Aug 2005 19:10:37 +0200 Message-ID: <18954.1124298637@phk.freebsd.dk> Sender: phk@phk.freebsd.dk Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/kern kern_conf.c src/sys/sys conf.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2005 17:10:40 -0000 In message <43036E25.6010508@root.org>, Nate Lawson writes: >Is it guaranteed that prep_cdevsw() won't be called twice without a call >to fini_cdevsw()? Otherwise, the shadow cdevsw could leak when its >pointer is set to NULL. I'm not familiar with this code, just asking. There's a flag that prevents controls the call to prep_ -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.