From owner-svn-src-all@FreeBSD.ORG  Tue Dec 10 04:56:34 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 662B488E;
 Tue, 10 Dec 2013 04:56:34 +0000 (UTC)
Received: from mail107.syd.optusnet.com.au (mail107.syd.optusnet.com.au
 [211.29.132.53])
 by mx1.freebsd.org (Postfix) with ESMTP id 2520111E6;
 Tue, 10 Dec 2013 04:56:33 +0000 (UTC)
Received: from c122-106-156-23.carlnfd1.nsw.optusnet.com.au
 (c122-106-156-23.carlnfd1.nsw.optusnet.com.au [122.106.156.23])
 by mail107.syd.optusnet.com.au (Postfix) with ESMTPS id 59087D43CEB;
 Tue, 10 Dec 2013 15:56:24 +1100 (EST)
Date: Tue, 10 Dec 2013 15:56:21 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Justin Hibbits <chmeeedalf@gmail.com>
Subject: Re: svn commit: r259080 - in head/sys: dev/iicbus geom/cache
 geom/journal
In-Reply-To: <20131208013614.6dc63ef9@zhabar.gateway.2wire.net>
Message-ID: <20131210155324.R1022@besplex.bde.org>
References: <201312071955.rB7JtYNH001792@svn.freebsd.org>
 <20131208123144.U883@besplex.bde.org>
 <20131208013614.6dc63ef9@zhabar.gateway.2wire.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.1 cv=bpB1Wiqi c=1 sm=1 tr=0
 a=ebeQFi2P/qHVC0Yw9JDJ4g==:117 a=PO7r1zJSAAAA:8 a=3HaF-T8NxwoA:10
 a=kj9zAlcOel0A:10 a=JzwRw_2MAAAA:8 a=ssdoF7uQumEA:10
 a=9pnJ-HnNXQN87wXru4sA:9 a=CjuIK1q_8ugA:10
Cc: svn-src-head@freebsd.org, Justin Hibbits <jhibbits@freebsd.org>,
 src-committers@freebsd.org, svn-src-all@freebsd.org,
 Bruce Evans <brde@optusnet.com.au>
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Dec 2013 04:56:34 -0000

On Sun, 8 Dec 2013, Justin Hibbits wrote:

> On Sun, 8 Dec 2013 13:53:30 +1100 (EST)
> Bruce Evans <brde@optusnet.com.au> wrote:
>
>> On Sat, 7 Dec 2013, Justin Hibbits wrote:
>[>]* [...]
>>> Modified: head/sys/geom/cache/g_cache.c
>>> ==============================================================================
>>> --- head/sys/geom/cache/g_cache.c	Sat Dec  7 19:39:38
>>> 2013	(r259079) +++ head/sys/geom/cache/g_cache.c	Sat
>>> Dec  7 19:55:34 2013	(r259080) @@ -67,7 +67,7 @@ static
>>> u_int g_cache_used_hi = 20; static int
>>> sysctl_handle_pct(SYSCTL_HANDLER_ARGS)
>>> {
>>> -	u_int val = *(u_int *)arg1;
>>> +	int val;
>>> 	int error;
>>>
>>> 	error = sysctl_handle_int(oidp, &val, 0, req);
>>
>> This adds the larger non-style bug that val is used uninitialized.
>> Compilers should warn about this.  This results in stack garbage
>> being copied out instead of the "old" value.
>> ...
> I just reverted these two changes in r259096.  Rather than fix what I
> did and change the rest of the files, I'm leaving them for another day,
> and reverted my changes so they're at least back to the working order
> from before.

Thanks.

Does it work to just remove the check for val < 0?

Bruce