From owner-freebsd-bugs@freebsd.org  Sat Jan 21 00:09:38 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C568CB8228
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sat, 21 Jan 2017 00:09:38 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BC1113A5
 for <freebsd-bugs@FreeBSD.org>; Sat, 21 Jan 2017 00:09:38 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0L09cQR014485
 for <freebsd-bugs@FreeBSD.org>; Sat, 21 Jan 2017 00:09:38 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 175314] [regression] bsdgrep(1) broken multidot escaping since
 r225435
Date: Sat, 21 Jan 2017 00:09:38 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: bsdports@kyle-evans.net
X-Bugzilla-Status: In Progress
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc attachments.created
Message-ID: <bug-175314-8-hWBumLF6sY@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-175314-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-175314-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jan 2017 00:09:38 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D175314

Kyle Evans <bsdports@kyle-evans.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bsdports@kyle-evans.net

--- Comment #1 from Kyle Evans <bsdports@kyle-evans.net> ---
Created attachment 179167
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179167&action=
=3Dedit
Proposed patch to address bsdgrep abusing memory

This was irritating to track down. There were two major problems here:

1.) wescmap was being built on top of uninitialized memory -- therefore, ev=
ery
dot was theoretically escaped with junk=3Dtrue
2.) The pre-processed pattern never makes it to fg->pattern, so escmap (also
uninitialized memory) was being built based on the processed pattern (witho=
ut
escapes)

This caused mass-hilarity and there's no way this could have worked since
import. Attached patch addresses both issues by switching both xmalloc()'s =
to
xcalloc and making a copy of the original pat (sans start marker at least) =
to
examine for escapes.

I also touched formatting a bit in the area that I had to make more changes=
 to,
because it was difficult to parse through at first.

--=20
You are receiving this mail because:
You are the assignee for the bug.=