Date: Mon, 2 Nov 2020 11:40:18 +0100 From: Mateusz Piotrowski <0mp@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, Niclas Zeising <zeising@freebsd.org> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r553700 - in head/x11-fonts: xorg-fonts-100dpi xorg-fonts-75dpi xorg-fonts-cyrillic xorg-fonts-miscbitmaps xorg-fonts-truetype xorg-fonts-type1 Message-ID: <501b95d3-521c-c73a-438e-97718c9208c6@FreeBSD.org> In-Reply-To: <20201102103029.urikofjptnrxub5d@ivaldir.net> References: <202010301610.09UGAFhS035068@repo.freebsd.org> <20201102080745.ajba7qpm7h73xn2a@aching.in.mat.cc> <f9e57cf0-554b-afec-73d1-ff31f9af4d75@freebsd.org> <20201102103029.urikofjptnrxub5d@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/2/20 11:30 AM, Baptiste Daroussin wrote: > On Mon, Nov 02, 2020 at 11:22:42AM +0100, Niclas Zeising wrote: >> On 2020-11-02 09:07, Mathieu Arnold wrote: >>> On Fri, Oct 30, 2020 at 04:10:15PM +0000, Mateusz Piotrowski wrote: >>>> Author: 0mp >>>> Date: Fri Oct 30 16:10:15 2020 >>>> New Revision: 553700 >>>> URL: https://svnweb.freebsd.org/changeset/ports/553700 >>>> >>>> Log: >>>> Switch x11-fonts/xorg-fonts-* to USES=metaport >>>> >>>> I believe that the FONTDIR could be renamed to _FONTDIR and the RUN_DEPENDS >>>> sorted, but let's do it another time to keep the diff small. Also, >>>> prefixing non-standard variables with "_" is not officially documented yet >>>> in the Porter's Handbook (it's only the convention suggested by portclippy, >>>> which itself is not mentioned there yet). >>> It would probably be better to remove FONTDIR and switch to package >>> dependecies instead of files, these port do not need the actual files, >>> but they need that the depending package be installed. >>> >> I told Mateusz to leave the FONTDIR thing alone, since there are references >> to it throughout the ports tree, and I am worried that changing or deleting >> it here would cause follow on effects. > Given how FONTDIR is used in those ports, I don't see how it is possible that it > has follow on effects. I've grepped the ports tree, Niclas, and it seems like those FONTDIR variables are safe to remove. I'll post a patch to phabricator shortly. Cheers! Mateusz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?501b95d3-521c-c73a-438e-97718c9208c6>