From nobody Tue Sep 26 17:34:06 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rw6LM5wgzz4vRGY for ; Tue, 26 Sep 2023 17:34:19 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rw6LM4KjHz3D3c for ; Tue, 26 Sep 2023 17:34:19 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-405361bb949so100859735e9.1 for ; Tue, 26 Sep 2023 10:34:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695749658; x=1696354458; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p3MMkurwZUPsT35iXJhOJ5ZCgMsiUjZZRKSH44tfcVc=; b=VeDmH3mjf/L2TYg85lvb4rJ5lHBCg2oleNqFmDEFKaqKdJ7MrZldNsZlN588IdQbQ/ q6WLFgpjEP6PxuMV0I4ffaotNmsefWd0TgCbxpyaRzQOrf0d9Bn1jcGdwN5IA4WJuh4E /uwUG62RNPDy+q1xkJnB9Mk24fiQKinbkqA17Ar8mrpJCfhVYQdKXXylUdozWOn0KI01 nE+yaX1wMxloPy2o3eXic398Ys3EXRNE98neVxf2d66r9kFagk74lgCGOXY2a6rQ7pYB vaJ8dm/7+A0x9hohSQnjXwHYoYg6BPIo6yXP1+2cLpKw0CLRtzOWtWZHYRmAD6OBh8nw i70Q== X-Gm-Message-State: AOJu0YxgXB18R26MLio3RhtB/VmIYlZMcWU8vPNr3OPxUDINgnmx+qGK Sn6UxwAsLyA1osn4Zm2Is1AsDQ== X-Google-Smtp-Source: AGHT+IHxiq6OjWA+BTKe/d2h/y8ZLw6B1FCy+wm+IEoEGWR6whfjDy75HtdKz0XEeT+ySdF/Cr+qaw== X-Received: by 2002:a05:600c:2294:b0:401:c338:ab96 with SMTP id 20-20020a05600c229400b00401c338ab96mr9088151wmf.34.1695749657394; Tue, 26 Sep 2023 10:34:17 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id k12-20020a7bc40c000000b003fc04d13242sm18726390wmi.0.2023.09.26.10.34.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Sep 2023 10:34:17 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: e6dc6a27230f - main - sys/conf/newvers.sh: whack sccs tag From: Jessica Clarke In-Reply-To: <52507A54-AAB7-43E9-BD06-41B9C78CF296@panasas.com> Date: Tue, 26 Sep 2023 18:34:06 +0100 Cc: Warner Losh , Mateusz Guzik , src-committers , "" , "" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202309261437.38QEbWmw002059@gitrepo.freebsd.org> <52507A54-AAB7-43E9-BD06-41B9C78CF296@panasas.com> To: Ravi Pokala X-Mailer: Apple Mail (2.3731.600.7) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4Rw6LM4KjHz3D3c On 26 Sep 2023, at 18:32, Ravi Pokala wrote: >=20 > In that case, an updated comment seems appropriate, so it=E2=80=99s = not removed again. https://reviews.freebsd.org/D41984 > -Ravi (rpokala@) >=20 > From: on behalf of Warner Losh = > Date: Tuesday, September 26, 2023 at 07:51 > To: Mateusz Guzik > Cc: src-committers , = "" , = "" > Subject: Re: git: e6dc6a27230f - main - sys/conf/newvers.sh: whack = sccs tag >=20 > Can you put this back? It is still useful. I have automated scripts = that look for this pattern to find the version of a core dump. There are = no other ways that are as reliable to find this data. Some other = heuristics exist, but my experience with snagging data from maybe a = thousand core dumps from $WORK's network found issues in all the = alternatives. It's why I didn't whack it already. Even though the text = says SCCS which is prehistory for this project, it's still in use today. > Warner >=20 > On Tue, Sep 26, 2023, 8:37 AM Mateusz Guzik wrote: >>=20 >>=20 >> The branch main has been updated by mjg: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3De6dc6a27230f836a131118326731b7c5= fd417723 >>=20 >> commit e6dc6a27230f836a131118326731b7c5fd417723 >> Author: Mateusz Guzik >> AuthorDate: 2023-09-26 14:36:51 +0000 >> Commit: Mateusz Guzik >> CommitDate: 2023-09-26 14:36:51 +0000 >>=20 >> sys/conf/newvers.sh: whack sccs tag >>=20 >> In the same spirit as removing cvs $FreeBSD$ tags. >>=20 >> Sponsored by: Rubicon Communications, LLC ("Netgate") >> --- >> sys/conf/newvers.sh | 2 -- >> 1 file changed, 2 deletions(-) >>=20 >> diff --git a/sys/conf/newvers.sh b/sys/conf/newvers.sh >> index 73fd6857d307..18b1817ca287 100644 >> --- a/sys/conf/newvers.sh >> +++ b/sys/conf/newvers.sh >> @@ -311,11 +311,9 @@ fi >>=20 >> vers_content_new=3D$(cat << EOF >> $COPYRIGHT >> -#define SCCSSTR "@(#)${VERINFO}" >> #define VERSTR "${VERSTR}" >> #define RELSTR "${RELEASE}" >>=20 >> -char sccs[sizeof(SCCSSTR) > 128 ? sizeof(SCCSSTR) : 128] =3D = SCCSSTR; >> char version[sizeof(VERSTR) > 256 ? sizeof(VERSTR) : 256] =3D = VERSTR; >> char compiler_version[] =3D "${compiler_v}"; >> char ostype[] =3D "${TYPE}";