From owner-freebsd-current@FreeBSD.ORG Wed Mar 10 21:56:58 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BA9F11065670 for ; Wed, 10 Mar 2010 21:56:58 +0000 (UTC) (envelope-from giovanni.trematerra@gmail.com) Received: from mail-fx0-f223.google.com (mail-fx0-f223.google.com [209.85.220.223]) by mx1.freebsd.org (Postfix) with ESMTP id 4EB178FC1E for ; Wed, 10 Mar 2010 21:56:58 +0000 (UTC) Received: by fxm23 with SMTP id 23so7671259fxm.3 for ; Wed, 10 Mar 2010 13:56:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=qmnpJ5cKQGpJEZ+xl3xuR4CDpFGZasq0r5hCO8eLGgE=; b=acRvZlF8i6tDDDf8NV1sWargWRcSsx/fz9JCIv65NM53wdM7jzk0FJWDSFu8/uju2U qkT9XSypMtZ/Bpm+YWlpohfHRXeLtIVmOa/D8OuF1dUk3iu93xoZh+h/2AO5Zx9knTtw hkkM51R+zRGmw5QMWtlatE2NtgtOPkAnj5ZOc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=UBzKFXaE1wY7sew2oNpgBfQ6LmP0q0PosiZ7vEz8Mbm7rz7XFbdfe+ve0vt0m581Lq vg0tllXuTBwHAm+imOn2Hq65w4zScXXZLd2422YJawNxpA3gU7kercMOQjlStxGkcLhE 9YccOa0QMO9q+kAGHD/E26XWyN1spGpOZpAZA= MIME-Version: 1.0 Received: by 10.223.5.211 with SMTP id 19mr2355509faw.63.1268258217348; Wed, 10 Mar 2010 13:56:57 -0800 (PST) In-Reply-To: <7d6fde3d1003070224k3626a9b5y98c11a43eef1bed4@mail.gmail.com> References: <7d6fde3d1003070207q621e69ado2cb64e431feacd76@mail.gmail.com> <7d6fde3d1003070224k3626a9b5y98c11a43eef1bed4@mail.gmail.com> Date: Wed, 10 Mar 2010 22:56:57 +0100 Message-ID: <4e6cba831003101356i534341ffr2961b983854ab788@mail.gmail.com> From: Giovanni Trematerra To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: FreeBSD Current Subject: Re: Removing USB keyboard after filesystems synced causes panic with destroyed mutex twa(4)? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2010 21:56:58 -0000 On Sun, Mar 7, 2010 at 11:24 AM, Garrett Cooper wrote: > On Sun, Mar 7, 2010 at 2:07 AM, Garrett Cooper wrote= : >> Hi Alexander and Hans, >> =A0 =A0I recently did the following which generated a panic on a >> 9-CURRENT kernel compiled on the 26th: >> >> 1. Executed reboot >> 2. Removed keyboard. >> 3. Some time after `All buffers synced\nUptime: ...' was displayed, >> the keyboard was registered disconnected. >> 4. The interrupt was delivered to my twa(4) enabled card and the >> kernel panicked, like so: >> >> ugen2.2: at usbus2 (disconnected) >> uhub8: at uhub2, port 1, addr 2 (disconnected) >> ugen2.3: at usbus2 (disconnected) >> ukbd0: at uhub8, port 3, addr 3 (disconnected) >> uhid0: at uhub8, port 3, addr 3 (disconnected) >> panic: mtx_lock_spin() of destroyed mutex @ /usr/src/sys/dev/twa/tw_cl_i= ntr.c:88 >> >> cpuid =3D 1 >> KDB: enter: panic >> [thread pid 12 tid 100025 ] >> Stopped at =A0 =A0 =A0 =A0 kdb_enter+0x3d: movq =A0 =A0 $0,0x40289c(%rip= ) >> db> >> >> =A0 =A0I wish I could provide you with more details, but unfortunately I >> the USB bus isn't registering the fact that I'm reattaching the >> keyboard right now and the box won't reboot automatically :( (didn't >> set the right sysctl beforehand to panic automatically). I'll try and >> reproduce the issue again, but I was just wondering whether or not you >> guys had seen this problem before. > > =A0 =A0Phew... it's reproducible with that kernel. Here's what I did > exactly (because my original directions were incorrect): > =A0 =A01. Hit power button (for S5). > =A0 =A02. Disconnect keyboard RIGHT as `Uptime: ...' is displayed. > =A0 =A0Kernel panicked on my system again. Now to figure out if it still > exists with a kernel compiled today, and also how to debug it if it > still does exist :/... > Thanks, > -Garrett Hi Garrett, Could you please try the patch below and report back? Thank you diff -r cab6489de66d sys/dev/twa/tw_cl_intr.c --- a/sys/dev/twa/tw_cl_intr.c Wed Mar 03 04:51:13 2010 -0500 +++ b/sys/dev/twa/tw_cl_intr.c Wed Mar 10 06:29:05 2010 -0500 @@ -75,9 +75,12 @@ tw_cl_interrupt(struct tw_cl_ctlr_handle if (ctlr =3D=3D NULL) goto out; - /* If we get an interrupt while resetting, it is a shared - one for another device, so just bail */ - if (ctlr->state & TW_CLI_CTLR_STATE_RESET_IN_PROGRESS) + /* + * If we get an interrupt while resetting or shutting down, + * it is a shared one for another device, so just bail + */ + if (ctlr->state & TW_CLI_CTLR_STATE_RESET_IN_PROGRESS || + (ctrl->state & TW_CLI_CTLR_STATE_ACTIVE) =3D=3D 0) goto out; /*